rest: set workflow status to pending after starting the workflow #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audrium
force-pushed
the
366-new-pending-state
branch
3 times, most recently
from
5d6f418 to
0f248dc
Compare
| @@ -125,6 +127,18 @@ def get_workflow_name(workflow): | |||
| return workflow.name + "." + str(workflow.run_number) | |||
|
|
|||
|
|
|||
| def get_workflow_status_name(workflow): | |||
There was a problem hiding this comment.
Have you tried to move such logic into a new property in REANA-DB? (asking just in case you already found a blocker 😄 ). We could have something like Workflow.status_ui (this name is bad, this is just a placeholder) which could be a hybrid property. This way we could perhaps overwrite the .in_ method for that property (useful for filtering), and also we wouldn't break the UI nor the client (this would access hypothetical Workflow.status_ui).
On the one hand, if we do such a split I feel it should be close to the models, on the other hand, I see it might be confusing to decide which one to use. Let me know what you think.
There was a problem hiding this comment.
Created issue to follow up on this here
audrium
force-pushed
the
366-new-pending-state
branch
2 times, most recently
from
dccd29a to
8d494f3
Compare
diegodelemos
approved these changes
Apr 27, 2021
audrium
force-pushed
the
366-new-pending-state
branch
from
8d494f3 to
ae4f10e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #363
Depends on reanahub/reana-db#123 (tests fail because
pendingstatus is not present yet)Changes
Sets workflow status to
pendingright after the workflow has been startedAddsget_workflow_status_name()function to return back the workflow statuspendingstatus should be transparent to the user, therefore in that case thequeuedstatus is returnedModifiesget_workflows()endpoint to includependingworkflows if filtered byqueuedstatusHow to test
I've tested it by running simple
helloworlddemo and modifying reana_workflow_engine_serial by addingjust before
publish_workflow_start(). In this case we can simulate that workflow is stuck a bit inpendingstate.In addition these lines could be commented to inspect thependingstatus using cli (note that UI will break, since the new state is not supported there)