Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test[ATLAS-104]: Adding Unit Tests for Date & Time Module #55

Conversation

RgnDunes
Copy link
Collaborator

@RgnDunes RgnDunes commented Jan 18, 2024

Description

This PR adds test cases for Date & Time Module for below api's:

  • add
  • substract
  • formatDate
  • formatDateTime
  • formatTime
  • getFirstDayOfWeek
  • getQuarter
  • getRelativeTime
  • getWeek
  • getWeekdays
  • isAfter
  • isBefore
  • isLeapYear
  • isSameDay
  • isValidDate
  • parseDateTime

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-104
Slack thread (if any) NA
Product spec Date Module - i18nify , Date & Time Usage in Merchant Dashboard
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Is your change backward compatible ?
  • Tested on major browsers (Chrome, Firefox, Safari, IE) ?
  • Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

  • Add Jira ID(s) in PR title and in the description?
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code is written in TypeScript and follows the coding standards of the project.
  • I have added relevant documentation and updated the README if necessary.
  • My commit messages are clear and follow the project's commit message conventions.
  • Is any external library added?
  • My changes do not introduce any new runtime errors or warnings.
  • All relevant unit tests have been added/updated in my PR for the change.
  • Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
  • Any manual dev testing done by you on beta/func environment?
  • Reviewer added (SLA 2 days)

Reviewer Checklist

  • Sufficient QA/Dev-Testing is done with proof (test cases list)
  • Ensure that the change in bundle size falls within the acceptable range.

PR Title Format

Format: <type>: <subject>

Types can be as follows:

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: a37fdd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@RgnDunes RgnDunes marked this pull request as draft January 18, 2024 19:55
@RgnDunes RgnDunes changed the title feat[ATLAS-104]: Adding Unit Tests for Date & Time Module test[ATLAS-104]: Adding Unit Tests for Date & Time Module Jan 18, 2024

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (462add3) 42.85% compared to head (a37fdd3) 85.18%.
Report is 1 commits behind head on ATLAS-104-date-module-and-ap-is-development.

Additional details and impacted files
@@                               Coverage Diff                                @@
##           ATLAS-104-date-module-and-ap-is-development      #55       +/-   ##
================================================================================
+ Coverage                                        42.85%   85.18%   +42.32%     
================================================================================
  Files                                               48       49        +1     
  Lines                                              574      594       +20     
  Branches                                           156      163        +7     
================================================================================
+ Hits                                               246      506      +260     
+ Misses                                             322       87      -235     
+ Partials                                             6        1        -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@RgnDunes RgnDunes changed the base branch from ATLAS-104-date-module-and-ap-is-development to master January 24, 2024 08:32

This comment has been minimized.

@RgnDunes RgnDunes changed the base branch from master to ATLAS-104-date-module-and-ap-is-development January 24, 2024 08:32
@rzpcibot
Copy link
Contributor

rzpcibot commented Jan 24, 2024

Warnings
⚠️ Your PR has over 600 lines of code additions 😱 . Try to breakup into separate PRs 👍

Bundle Size Report

Files

click to expand/collapse
🟢 No Change 🗑 File Deleted 🆕 New File 📈 Size Increased 👍 Size Reduced
Parsed (kb)
🚦 File Name Base PR Diff %
🟢 cjs/index.js 66.53 66.53 $\textcolor{green}{0}$ 0
🟢 esm/index.js 66.38 66.38 $\textcolor{green}{0}$ 0
🟢 umd/index.js 74.41 74.41 $\textcolor{green}{0}$ 0

Generated by 🚫 dangerJS against a34962c

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

…development' into ATLAS-104-date-module-and-apis-development-unit-tests

This comment has been minimized.

@RgnDunes RgnDunes marked this pull request as ready for review January 24, 2024 12:57

This comment has been minimized.

@RgnDunes RgnDunes changed the base branch from ATLAS-104-date-module-and-ap-is-development to master January 24, 2024 13:27
@RgnDunes RgnDunes changed the base branch from master to ATLAS-104-date-module-and-ap-is-development January 24, 2024 13:31

This comment has been minimized.

…development' into ATLAS-104-date-module-and-apis-development-unit-tests

This comment has been minimized.

@RgnDunes RgnDunes marked this pull request as draft February 8, 2024 09:07
…development' into ATLAS-104-date-module-and-apis-development-unit-tests

This comment has been minimized.

Copy link
Contributor

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a37fdd3. ± Comparison against base commit 462add3.

@RgnDunes RgnDunes marked this pull request as ready for review February 14, 2024 07:31
@RgnDunes RgnDunes merged commit e591663 into ATLAS-104-date-module-and-ap-is-development Feb 14, 2024
7 checks passed
@RgnDunes RgnDunes deleted the ATLAS-104-date-module-and-apis-development-unit-tests branch February 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants