-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ATLAS-104]: Introducing Date & Time Module #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e591663 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RgnDunes
changed the title
feat: Introducing Date & Time Module
feat[ATLAS-104]: Introducing Date & Time Module
Jan 18, 2024
Bundle Size Report
|
🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
---|
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
🟢 | cjs/index.js |
70.97 |
70.97 |
|
0 |
🟢 | esm/index.js |
0.64 |
0.64 |
|
0 |
🟢 | umd/index.js |
80.34 |
80.34 |
|
0 |
…le-and-ap-is-development
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…le-and-ap-is-development
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* refactor parseDateTime module * add readme docs for dateTime module * restructure README * updated isValidDate docs * replace i18nify with i18nify-js * update README * [docs]: update README as per the changes in api contracts in dev PR
* add test fils * add UT for add - dateTime module * migrate test files * add UT for formatDate - dateTime module * add UT for formatDateTime - dateTime module * fix formatDate * add UT for formatTime - dateTime module * add leftout locales date format * add UT for getQuarter - dateTime module * add UT for getQuarter - dateTime module * add UT for getRelativeTime - dateTime module * add UT for getWeek - dateTime * add UT for getWeekdays - dateTime * add UT for isAfter - dateTime * add UT for isBefore - dateTime * add UT for isLeapYear - dateTime * add UT for isSameDay - dateTime * fix numerals test case * add date format in stringToDate * add UT for parseDateTime - dateTime * add UT for subtract - dateTime * add UT for stringToDate - utils - dateTime * comment failing test cases * remove extra files * [fix]: fix failing UT * [fix]: fix failing UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new module called Date & Time Module to handle all the validation, parsing, and formatting of Date and Time. This module consists of below api's:
PR for README: #56
PR for UTs: #55
Changes Made
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>
Types can be as follows:
feat
: (new feature for the user, not a new feature for build script)fix
: (bug fix for the user, not a fix to a build script)docs
: (changes to the documentation)style
: (formatting, missing semi colons, etc; no production code change)refactor
: (refactoring production code, eg. renaming a variable)test
: (adding missing tests, refactoring tests; no production code change)chore
: (updating grunt tasks etc; no production code change)