Prepare release 1.6.1 #130

razman786 · 2022-05-09T14:33:12Z

Tigger version 1.6.1 with support for Ubuntu 22.04:

Proposed steps:

Process PR 37 for tigger-lsm first (Fixes angle error with mosaics tigger-lsm#37). PR 37 for tigger-lsm already includes a refined PR 36 (Fixes issue #35 - FITS CUNIT 'M/S' header. tigger-lsm#36) for convenience. This is what the newer features and testing of Tigger v1.6.1 has been worked upon.
Please note I've not looked into or tested PR 34 for tigger-lsm (Add LSM to Reg converter tigger-lsm#34)
Currently the setup.py of Tigger v1.6.1 expects PR 37 (at minimum) to form tigger-lsm v1.7.1 for processing mosaic and FITS files with header issues. Therefore release v1.7.2 or use tigger-lsm PR 37 for this PR.
Process PR Closes issue #128 - FITS headers after arithmetic operations #132 .
Process this PR for Tigger v1.6.1

N.B. you can test ARM64 Ubuntu 22.04 via qemu on x86 - it's slow and painful but does work, eventually.

EDIT: Fixed typo

Changes:

Supports Ubuntu 22.04
Beta support for Ubuntu 22.04 ARM64 (with PyQwt deb pkg) - it should allow a Mac M1 user to use Ubuntu 22.04 for ARM64 with UTM virtualisation on Mac OS X
Dependent on the latest tigger-lsm (i.e. PR 37)
Fixed live profile selection when using mosaic images (and tigger-lsm PR 37)
Fixed float errors with updated library API's
Re-enabled splash screen
Fixes venv pip3 bug
Updated URL's
GitHub Actions are now compatible with 'act' for running locally
Actions now test VENV installations on Ubuntu 20.04 and 22.04
Improved Action tests and logging
Failed Actions are processed by an error reporting step
Copyright notice years updated and redundant UTF-8 file declarations removed
Code was checked for consistency with v1.5.1 as part of Image arithmetic not handing NaNs / blanks correctly #129 and PR Closes issue #128 - FITS headers after arithmetic operations #132
Image zooming refined (trackpad and mouse)
Dockable widget handling improved, window and image sizes should remain better
Minor file formatting
Updated README.rst
Updated CHANGELOG.rst

…e install builds PyQWT from source on 22.04.

QPoint's have been used for drawImage. Sizing and indexes also cast to ints where needed.

* Actions are now compatible with 'act' for running locally * Added support for Ubuntu 22.04 * VENV installations are tested for Ubuntu 20.04 and 22.04 * Tests now confirm that the installation was successful * Tests also include the loading of FITS and model files * Flake8 tests were repositioned to the forefront * Logging output was reduced and log files are shown upon error

* Added logging * Added failed jobs summary and output * Simplified check installation test

works much better with a mouse.

pane that displays the FITS header information.

Tigger config file.

floats and ints. The code was also checked against verion 1.5.1 for inconsistencies.

razman786 · 2022-05-17T08:36:25Z

As a note, the recent failing tests are not due to Tigger, but the Actions VM's failing for 18.04 and 22.04 when downloading and installing deb packages via apt. Tests pass locally using 'act' as was the case with 20.04.

GitHub (not seen locally).

bennahugo · 2022-05-23T10:15:04Z

ok to test

bennahugo · 2022-05-23T11:24:24Z

Trying to load in an image with the menu I run across:

Welcome to Tigger 1.6.1
Please wait a second while the GUI starts up.
Detected screen size 1200x1920, usable area 1200x1890
Traceback (most recent call last):
  File "/home/hugo/workspace/tigger/TigGUI/Images/Manager.py", line 161, in loadImage
    layout.addWidget(_flabel, 0, 3)
AttributeError: 'NoneType' object has no attribute 'addWidget'

It does not happen when you load in images using the command line

razman786 · 2022-05-23T11:28:24Z

Trying to load in an image with the menu I run across:

Welcome to Tigger 1.6.1
Please wait a second while the GUI starts up.
Detected screen size 1200x1920, usable area 1200x1890
Traceback (most recent call last):
  File "/home/hugo/workspace/tigger/TigGUI/Images/Manager.py", line 161, in loadImage
    layout.addWidget(_flabel, 0, 3)
AttributeError: 'NoneType' object has no attribute 'addWidget'

It does not happen when you load in images using the command line

I cannot replicate it. What version of Ubuntu are you testing with?

bennahugo · 2022-05-23T11:48:40Z

Running Ubuntu 18.04 with my previous testing environment

razman786 · 2022-05-23T11:59:52Z

Ah ok that explains it. My Ubuntu 18.04 setup passed away along with the laptop it was on :( But I was able to replicate the issue. It seems that some Ubuntu's use the native file dialog by default and others don't... Give the latest commit a spin, it should work, and if the widget layout cannot be customised it will not show the preview pane.

bennahugo · 2022-05-23T12:30:19Z

Ok thanks @razman786 I've run through it for a bit and I can't see anything majorly amiss. I will accept and merge this one!

razman786 added 28 commits May 6, 2022 12:31

Fixed install script detection of pip3 when in a venv.

579d247

Updated tigger-lsm dependency to version 1.7.1

6644f78

Version bump to 1.6.1

0412b90

Updated README.rst with tigger-lsm version 1.7.1.

b423162

Reimplemented Tigger's splash screen - useful when opening larger files.

af8492d

Updated installer script and setup.py for Ubuntu 22.04. Currently, th…

8ef541b

…e install builds PyQWT from source on 22.04.

Fix float error with updated API's/libs. Floating point Rect's and

7a7702e

QPoint's have been used for drawImage. Sizing and indexes also cast to ints where needed.

Fixed install (via source) of PyQwt for Ubuntu 22.04.

9381a5c

Updated install script to use new deb package for PyQwt on Ubuntu 22.04.

749c439

Added new deb packages for PyQwt on Ubuntu 22.04.

3971686

Fixed float errors with updated API's/libs when loading a model.

8dd7599

Fixed venv installation.

bf0b00d

Fixed from source build for Ubuntu 22.04.

d9dcad4

Updated github URL to ratts-ru.

84a8cf8

Updated URL's to use ratt-ru.

6628492

Added .local to $PATH while installing.

cbe4831

Fixed VENV installation.

35a53b8

Fixed source based installation, including with VENV.

891aa68

Added Ubuntu 22.04 to GitHub Actions.

ad705aa

Updated URL's to use ratt-ru.

0d4ea59

Fixed logging output for successful installation.

c61dab2

Fixed missed test updates for Ubuntu 22.04

e4b8b24

Updated GitHub Actions:

f060fd3

* Added logging * Added failed jobs summary and output * Simplified check installation test

Reformatted file

66b4049

Updated README.rst with Ubuntu 22.04 instructions.

c2493c0

Updated CHANGELOG for version 1.6.1

3719ba9

Fixed VENV vext.pyqt5 sipconfig error when installing on Ubuntu 22.04

ea0ab2a

razman786 added this to the 1.6.1 milestone May 9, 2022

razman786 self-assigned this May 9, 2022

razman786 added 6 commits May 15, 2022 11:48

Refined zoom by levels. Interaction with a trackpad is sensitive, but

510ff17

works much better with a mouse.

Added support to detect zooming on a trackpad or a mouse wheel

bea3596

The file selection dialog for opening FITS files now has a file preview

3b3f11a

pane that displays the FITS header information.

Updated CHANGELOG.rst for version 1.6.1

8d6af00

Fix none error when control dialog is loaded as a floating window from

d970567

Tigger config file.

Related to issue #129. The code has been refactored in terms of Qwt,

412d123

floats and ints. The code was also checked against verion 1.5.1 for inconsistencies.

razman786 added 9 commits May 17, 2022 09:42

Disabled apt upgrade for Actions, as there is currently an error on

99c25d0

GitHub (not seen locally).

Updated shebangs and removed utf-8 declarations.

8f0e432

Updated copyright notices.

df12995

Updated About dialog copyright notice.

f80bef2

Fixed live profile selection when using mosaic images

de75d3d

Updated compatible dependency versions

52486f1

Updated README.rst

34c1327

Updated README.rst badges and URL's

42f7145

Updated README.rst with pypi actions badge

b6cd842

razman786 changed the title ~~WIP: Prepare release 1.6.1~~ Prepare release 1.6.1 May 22, 2022

razman786 requested review from bennahugo and Athanaseus May 22, 2022 22:24

razman786 mentioned this pull request May 22, 2022

Fixes issue #35 - FITS CUNIT 'M/S' header. ratt-ru/tigger-lsm#36

Merged

Fixed window resinzing when dockwidget close while floating

0f6bd33

Fix native file dialog option for FITS header preview pane

0a01b5a

bennahugo approved these changes May 23, 2022

View reviewed changes

bennahugo merged commit bdfe29a into master May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare release 1.6.1 #130

Prepare release 1.6.1 #130

razman786 commented May 9, 2022 •

edited

Loading

razman786 commented May 17, 2022 •

edited

Loading

bennahugo commented May 23, 2022

bennahugo commented May 23, 2022 •

edited

Loading

razman786 commented May 23, 2022

bennahugo commented May 23, 2022

razman786 commented May 23, 2022

bennahugo commented May 23, 2022

Prepare release 1.6.1 #130

Prepare release 1.6.1 #130

Conversation

razman786 commented May 9, 2022 • edited Loading

razman786 commented May 17, 2022 • edited Loading

bennahugo commented May 23, 2022

bennahugo commented May 23, 2022 • edited Loading

razman786 commented May 23, 2022

bennahugo commented May 23, 2022

razman786 commented May 23, 2022

bennahugo commented May 23, 2022

razman786 commented May 9, 2022 •

edited

Loading

razman786 commented May 17, 2022 •

edited

Loading

bennahugo commented May 23, 2022 •

edited

Loading