-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #35 - FITS CUNIT 'M/S' header. #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can one of the admins verify this patch? |
A refined version of this PR has already been added to PR #37 for the purposes of PR 130 (ratt-ru/tigger#130). |
ok to test |
The failure stems from usage of format strings:
Recall that I added backport facilities for Python 2.7 to fix the previous Tigger. If you want to remove these go ahead. |
@bennahugo - Ah yes I recall now (took a bit). Is anyone using |
We just need to make sure that the current release only targets 3.x for those who are still on an older Tigger so we don't break the dependency tree. Then we can retire the failing build. |
Specifically this needs changing: https://github.com/ratt-ru/tigger-lsm/blob/master/setup.py#L32 |
Fixes issue #35 - FITS CUNIT 'M/S' header.
wcslib
needs 'M/S' to be lower case 'm/s' - a simple fix that updates the header.