-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an issue due to updating ruby_ntlm to 0.6.5 #271
Merged
cdelafuente-r7
merged 1 commit into
rapid7:master
from
zeroSteiner:fix/gss/ruby-ntlm-upgrade
Sep 9, 2024
Merged
Fix an issue due to updating ruby_ntlm to 0.6.5 #271
cdelafuente-r7
merged 1 commit into
rapid7:master
from
zeroSteiner:fix/gss/ruby-ntlm-upgrade
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a PR that changed how strings were being encoded that was added to ruby_ntlm 0.6.5 that is causing tests to break.
zeroSteiner
force-pushed
the
fix/gss/ruby-ntlm-upgrade
branch
from
September 5, 2024 18:38
6e9b999
to
6beae57
Compare
cdelafuente-r7
approved these changes
Sep 9, 2024
It looks good to me. I tested using with the RubySMB server and an username containing a non-ASCII character (connecting from Windows Explorer on Windows Server 2019):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a PR that changed how strings were being encoded that was added to ruby_ntlm 0.6.5 that is causing tests to break.
Tested that
ruby examples/tree_connect.rb --username юзер --password 123456 192.168.159.10 IPC$
continues to work. Things also still work with rubyntlm==0.6.4.