Adding NetrWkstaUserEnum implementation

[NtAlexio2]

This PR adds this request. By this we can modernize an old style Metasploit module here, just like #19170

Verification Steps

• [✅] bundle install

rake spec

• [✅] rake spec
• [✅] VERIFY no failures

[NtAlexio2]

Thank you very much, @smcintyre-r7, for your valuable suggestions! This was my first experience working with Ruby and the Metasploit Framework, and your insights have been incredibly helpful.

[smcintyre-r7]

I added some suggestions to fix some changes that were missing from the refactoring. I also figured out why the tests are failing and opened a PR with changes in #271 to fix it.

With all of the changes in place, the unit tests should be passing. Would you be able to rebase the branch to squash the history down a bit?

[NtAlexio2]

@smcintyre-r7 sure!

[smcintyre-r7]

Changes are looking good to me. I tested things by updating the examples/get_computer_info.rb script and then targeted a DC I used for testing. I logged into the DC and was able to observe my name show up.

Quick patch for testing:

git diff
diff --git a/examples/get_computer_info.rb b/examples/get_computer_info.rb
index 55ee17f..035b9e7 100644
--- a/examples/get_computer_info.rb
+++ b/examples/get_computer_info.rb
@@ -37,6 +37,10 @@ puts "Computer Name: #{info.wki100_computername.encode('utf-8')}"
 puts "LAN Group: #{info.wki100_langroup.encode('utf-8')}"
 puts "OS Version: #{info.wki100_ver_major}.#{info.wki100_ver_minor}"
 
+info = wkssvc.netr_wksta_user_enum
+require 'pry'
+binding.pry
+
 client.disconnect!

  : ruby_smb.pr: 27009:29:33 fedora-vm ruby_smb.pr bundle exec ruby examples/get_computer_info.rb 192.168.159.10 'smcintyre' 'Password1!'
SMB3 : (0x00000000) STATUS_SUCCESS: The operation completed successfully.
Binding to \wkssvc...
Bound to \wkssvc
[+] WKSSVC Connect
Platform: Win
Computer Name: DC
LAN Group: MSFLAB
OS Version: 10.0

From: /home/smcintyre/Repositories/ruby_smb.pr/examples/get_computer_info.rb:42 :

    37: puts "LAN Group: #{info.wki100_langroup.encode('utf-8')}"
    38: puts "OS Version: #{info.wki100_ver_major}.#{info.wki100_ver_minor}"
    39: 
    40: info = wkssvc.netr_wksta_user_enum
    41: require 'pry'
 => 42: binding.pry
    43: 
    44: client.disconnect!
    45: 
    46: 

[1] pry(main)> info
=> {:wkui0_entries_read=>9,
 :wkui0_buffer=>
  [{:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"}]}
[2] pry(main)> ssh 
[2] pry(main)> 

email: [email protected]                                                                                                                          
  !: ruby_smb.pr: 27009:40:42 fedora-vm ruby_smb.pr bundle exec ruby examples/get_computer_info.rb 192.168.159.10 'smcintyre' 'Password1!'
SMB3 : (0x00000000) STATUS_SUCCESS: The operation completed successfully.
Binding to \wkssvc...
Bound to \wkssvc
[+] WKSSVC Connect
Platform: Win
Computer Name: DC
LAN Group: MSFLAB
OS Version: 10.0

From: /home/smcintyre/Repositories/ruby_smb.pr/examples/get_computer_info.rb:42 :

    37: puts "LAN Group: #{info.wki100_langroup.encode('utf-8')}"
    38: puts "OS Version: #{info.wki100_ver_major}.#{info.wki100_ver_minor}"
    39: 
    40: info = wkssvc.netr_wksta_user_enum
    41: require 'pry'
 => 42: binding.pry
    43: 
    44: client.disconnect!
    45: 
    46: 

[1] pry(main)> info
=> {:wkui0_entries_read=>11,
 :wkui0_buffer=>
  [{:wkui0_username=>"smcintyre"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"},
   {:wkui0_username=>"DC$"}]}
[2] pry(main)> info.wkui0_buffer
=> [{:wkui0_username=>"smcintyre"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"},
 {:wkui0_username=>"DC$"}]
[3] pry(main)> info.wkui0_buffer.length
=> 11
[4] pry(main)> 

[smcintyre-r7]

Unit tests pass from a merged branch incorporating the changes from my last PR and last commit.