Fix Java Meterpreter Symlink Handling on Windows #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This edit uses javascript to exclude versioned files requirinig Java 7+.
zeroSteiner
force-pushed
the
fix/met/java/symlinks
branch
3 times, most recently
from
c267144 to
af89b27
Compare
|
This PR should be landed because the tests are passing in rapid7/metasploit-framework. Once this is landed, the Metasploit side of things should be laned after the last commit updating the testing definition is reverted: |
zeroSteiner
added a commit
to zeroSteiner/metasploit-framework
that referenced
this pull request
Dec 6, 2024
Includes changes from: * rapid7/metasploit-payloads#731 * rapid7/metasploit-payloads#730
zeroSteiner
added a commit
to zeroSteiner/metasploit-framework
that referenced
this pull request
Dec 6, 2024
Includes changes from: * rapid7/metasploit-payloads#731 * rapid7/metasploit-payloads#730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues in how the Java Meterpreter handles links and junctions when running on Windows. This issue arose when these tests failed due to the new addition of tests in rapid7/metasploit-framework#19554.
Along the way the following additional changes were made:
pom.xmlcompatibility checks for Java 6 were updated to use javascript to select versioned files, so all files lacking a version and marked for version 1-6 are included. This means new versioned files can be added in the future without troubleshooting and updating thispom.xml.For testing: