Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a test that should be working now #19621

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Remove a test that should be working now #19621

merged 4 commits into from
Dec 9, 2024

Conversation

zeroSteiner
Copy link
Contributor

This removes a test that should be fixed once this is landed:

Don't merge until then.

@cgranleese-r7 cgranleese-r7 added payload-testing-mettle-branch Runs framework and custom mettle PRs - https://github.com/rapid7/metasploit-framework/pull/19390 payload-testing-branch Runs framework and custom payloads PRs - https://github.com/rapid7/metasploit-framework/pull/19390 and removed payload-testing-mettle-branch Runs framework and custom mettle PRs - https://github.com/rapid7/metasploit-framework/pull/19390 labels Nov 7, 2024
@zeroSteiner zeroSteiner force-pushed the fix/met/java-win-symlink-tests branch from 9304b8e to 6274d04 Compare November 7, 2024 19:20
@smcintyre-r7 smcintyre-r7 marked this pull request as ready for review November 11, 2024 14:32
@zeroSteiner
Copy link
Contributor Author

The payloads PR should be landed first, then the last commit that updates the tests (6274d04) should be reverted for this to be landed.

@dledda-r7 dledda-r7 self-assigned this Nov 26, 2024
@cgranleese-r7 cgranleese-r7 mentioned this pull request Dec 5, 2024
Closed
@zeroSteiner zeroSteiner force-pushed the fix/met/java-win-symlink-tests branch 3 times, most recently from 647d113 to 1ef34d7 Compare December 5, 2024 18:43
@zeroSteiner zeroSteiner force-pushed the fix/met/java-win-symlink-tests branch from 1ef34d7 to 83fcc32 Compare December 6, 2024 17:32
dledda-r7
dledda-r7 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dledda-r7 dledda-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dledda-r7 dledda-r7 merged commit 3a2b5ce into rapid7:master Dec 9, 2024
82 checks passed
@dledda-r7 dledda-r7 added the rn-fix release notes fix label Dec 9, 2024
@dledda-r7
Copy link
Contributor

dledda-r7 commented Dec 9, 2024 •
edited
Loading

Release Notes

This fixes the symlinks handling by the Java Meterpreter on Windows targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dledda-r7 dledda-r7 dledda-r7 approved these changes

Assignees

@dledda-r7 dledda-r7

Labels
meterpreter payload-testing-branch Runs framework and custom payloads PRs - https://github.com/rapid7/metasploit-framework/pull/19390 rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeroSteiner @dledda-r7 @cgranleese-r7