Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Slideshow #225

Closed
wants to merge 1 commit into from
Closed

Dynamic Slideshow #225

wants to merge 1 commit into from

Conversation

mohsin-r
Copy link
Member

@mohsin-r mohsin-r commented May 23, 2023

Closes #318.

You can now add a slideshow that supports all panel types (text, image, chart, map).

⚠️ Caution: This PR makes breaking changes to the current schema, so people should be comfortable with the design before this is merged. The details are in the files, but here are the changes that would be needed to migrate current products:

  • For all the current slideshow panels, just change the type to image.
  • For all the current image panels, add an images array and drop your single image config inside that array.

Essentially, the current image panels now support multiple images (similar to chart panels) and the slideshow panels support all panel types instead of just images.

Feel free to play around with creating, editing, viewing etc. slideshows and suggest changes to design, implementation, etc.


This change is Reviewable

@mohsin-r
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic gallery - A gallery that supports all panel types
2 participants