Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-image slideshow issue #212

Closed
dan-bowerman opened this issue May 11, 2023 · 4 comments
Closed

Single-image slideshow issue #212

dan-bowerman opened this issue May 11, 2023 · 4 comments
Labels
Charts Issues concerning Highcharts graphing functionality Dynamic Issues concerning dynamic content slides Images Issues concerning image slides, galleries, or embedded multimedia Quality Assurance Tasks related to QA assessments

Comments

@dan-bowerman
Copy link
Member

Let me know if this is too much hassle to be worth it.

During the recent Testing Party, a few issues were logged that were the same underlying issue - single images were saved as slideshows with only one image in them, which added the inactive UI elements of the left and right paginator arrows. This is default Editor behaviour, it works well, but the "<" and ">" arrows seem to confuse users who are expecting to see more graphics.

Maybe a checkbox or an "auto" setting of an image slideshow (or any type of slideshow) to force the image panel to simply be an image panel without a gallery/slideshow? e.g., if there is only one image present, make it an image panel; if there are more, make it a slideshow?.

@dan-bowerman dan-bowerman added Quality Assurance Tasks related to QA assessments Priority: High This task is high priority and should be tackled soon Charts Issues concerning Highcharts graphing functionality Images Issues concerning image slides, galleries, or embedded multimedia Dynamic Issues concerning dynamic content slides labels May 11, 2023
@yileifeng
Copy link
Member

See slideshow-panel.vue in this repo and port the changes over for a quick fix.

Alternatively, a better solution might be to convert any single-image slideshows to an image panel before saving to the ZIP config. Would likely involve modifying the saveChanges method inside image-editor and would eliminate the dependence on the storylines viewer panel to detect for single-image slideshow panels.

@mohsin-r mohsin-r self-assigned this May 16, 2023
@dan-bowerman dan-bowerman removed the Priority: High This task is high priority and should be tackled soon label May 30, 2023
@dan-bowerman
Copy link
Member Author

Removing "High" priority - for the 9 products we recently pushed, we just manually changed these. We will want to revisit this when Editor development starts back up again.

@yileifeng
Copy link
Member

Should have a temp fix when ramp4-pcar4/story-ramp#358 is merged

@dan-bowerman
Copy link
Member Author

Implicated in #225, we can probably close this one (needs further review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Charts Issues concerning Highcharts graphing functionality Dynamic Issues concerning dynamic content slides Images Issues concerning image slides, galleries, or embedded multimedia Quality Assurance Tasks related to QA assessments
Projects
None yet
Development

No branches or pull requests

3 participants