-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resim
buckets parsing
#1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks
)) if package_address == Some(RESOURCE_PACKAGE) | ||
&& bp_name == FUNGIBLE_BUCKET_BLUEPRINT => | ||
{ | ||
"FungibleBucket".to_owned() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :). How did you spot this out of interest?
We should probably also handle FungibleProof
/NonFungibleProof
/FungibleVault
/NonFungibleVault
/FungibleResourceManager
/NonFungibleResourceManager
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
I was checking where else OwnValidation::IsBucket
enum variant is used and found this one.
I will add those missing ones in separate PR if that's ok.
Benchmark for 662b660Click to view benchmark
|
Summary
Add support for missing types:
FungibleBucket
andNonFungibleBucket
Testing
Respective tests added