Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types to scrypto-bindgen #1654

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

lrubasze
Copy link
Contributor

@lrubasze lrubasze commented Nov 23, 2023

Summary

Types added:

  • FungibleProof
  • NonFungibleProof
  • FungibleVault
  • NonFungibleVault

@lrubasze
Copy link
Contributor Author

@dhedey
Added missing types as per comment

Skipped FungibleResourceManager and NonFungibleResourceManager since they seem to be not exposed to scrypto.

Copy link

Benchmark for ee48891

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 75.3±0.94ms 75.6±0.43ms +0.40%
costing::decode_sbor 16.7±0.19µs 16.4±0.07µs -1.80%
costing::decode_sbor_bytes 51.5±0.33µs 50.5±0.92µs -1.94%
costing::deserialize_wasm 1421.0±17.73µs 1413.9±13.34µs -0.50%
costing::instantiate_flash_loan 4.5±0.75ms 4.4±0.70ms -2.22%
costing::instantiate_radiswap 6.8±0.05ms 6.6±0.04ms -2.94%
costing::spin_loop 26.0±0.37ms 26.8±0.20ms +3.08%
costing::validate_sbor_payload 31.3±0.41µs 31.4±0.23µs +0.32%
costing::validate_sbor_payload_bytes 404.4±7.37ns 397.7±11.85ns -1.66%
costing::validate_secp256k1 87.6±0.91µs 86.4±1.38µs -1.37%
costing::validate_wasm 44.3±0.22ms 43.8±0.36ms -1.13%
decimal::add/0 9.2±0.10ns 9.3±0.02ns +1.09%
decimal::add/rust-native 10.8±0.06ns 10.7±0.17ns -0.93%
decimal::add/wasmer 126.4±0.95ns 125.7±1.76ns -0.55%
decimal::add/wasmer-call-native 548.5±0.49ns 550.3±1.28ns +0.33%
decimal::add/wasmi 868.6±6.95ns 929.5±8.72ns +7.01%
decimal::add/wasmi-call-native 8.8±0.04µs 8.4±0.03µs -4.55%
decimal::div/0 198.7±1.54ns 199.0±0.62ns +0.15%
decimal::from_string/0 168.8±1.12ns 168.4±1.37ns -0.24%
decimal::mul/0 156.4±0.46ns 155.9±1.14ns -0.32%
decimal::mul/rust-native 154.6±0.20ns 152.4±0.89ns -1.42%
decimal::mul/wasmer 1682.2±7.53ns 1677.6±15.21ns -0.27%
decimal::mul/wasmer-call-native 714.7±1.06ns 702.7±7.39ns -1.68%
decimal::mul/wasmi 73.3±0.15µs 72.2±1.43µs -1.50%
decimal::mul/wasmi-call-native 8.7±0.13µs 8.5±0.02µs -2.30%
decimal::pow/0 726.7±2.35ns 732.6±11.03ns +0.81%
decimal::pow/rust-native 699.5±1.17ns 695.8±7.03ns -0.53%
decimal::pow/wasmer 7.3±0.01µs 7.3±0.01µs 0.00%
decimal::pow/wasmer-call-native 1192.4±4.64ns 1175.4±2.12ns -1.43%
decimal::pow/wasmi 347.4±0.32µs 339.6±1.45µs -2.25%
decimal::pow/wasmi-call-native 8.0±0.02µs 7.6±0.04µs -5.00%
decimal::root/0 9.5±0.06µs 8.6±0.12µs -9.47%
decimal::sub/0 9.3±0.09ns 9.4±0.04ns +1.08%
decimal::to_string/0 486.0±3.86ns 482.9±2.86ns -0.64%
precise_decimal::add/0 10.4±0.15ns 10.4±0.11ns 0.00%
precise_decimal::add/rust-native 12.3±0.11ns 12.3±0.07ns 0.00%
precise_decimal::add/wasmer 134.7±0.51ns 134.2±1.02ns -0.37%
precise_decimal::add/wasmer-call-native 575.2±0.57ns 573.0±6.01ns -0.38%
precise_decimal::add/wasmi 1106.8±10.06ns 1111.8±36.99ns +0.45%
precise_decimal::add/wasmi-call-native 9.3±0.07µs 8.9±0.10µs -4.30%
precise_decimal::div/0 322.9±2.59ns 324.1±1.40ns +0.37%
precise_decimal::from_string/0 214.2±1.92ns 213.6±2.68ns -0.28%
precise_decimal::mul/0 341.2±6.00ns 346.9±1.09ns +1.67%
precise_decimal::mul/rust-native 326.6±0.48ns 326.4±2.09ns -0.06%
precise_decimal::mul/wasmer 4.0±0.04µs 4.0±0.61µs 0.00%
precise_decimal::mul/wasmer-call-native 937.1±8.73ns 950.7±3.50ns +1.45%
precise_decimal::mul/wasmi 181.1±0.58µs 176.3±1.14µs -2.65%
precise_decimal::mul/wasmi-call-native 9.6±0.07µs 9.5±0.17µs -1.04%
precise_decimal::pow/0 1935.4±4.24ns 1940.2±9.74ns +0.25%
precise_decimal::pow/rust-native 1583.1±10.04ns 1545.1±31.08ns -2.40%
precise_decimal::pow/wasmer 17.9±0.06µs 18.2±0.01µs +1.68%
precise_decimal::pow/wasmer-call-native 2.3±0.00µs 2.3±0.02µs 0.00%
precise_decimal::pow/wasmi 882.6±0.71µs 856.7±8.26µs -2.93%
precise_decimal::pow/wasmi-call-native 18.9±0.03µs 18.0±0.06µs -4.76%
precise_decimal::root/0 67.2±0.21µs 66.4±0.04µs -1.19%
precise_decimal::sub/0 10.2±0.15ns 10.4±0.04ns +1.96%
precise_decimal::to_string/0 785.1±0.87ns 775.0±12.74ns -1.29%
schema::validate_payload 345.6±2.28µs 345.8±1.74µs +0.06%
transaction::radiswap 6.4±0.09ms 6.3±0.11ms -1.56%
transaction::transfer 2.0±0.00ms 2.0±0.02ms 0.00%
transaction_processing::prepare 3.1±0.03ms 3.1±0.03ms 0.00%
transaction_processing::prepare_and_decompile 7.2±0.07ms 7.1±0.06ms -1.39%
transaction_processing::prepare_and_decompile_and_recompile 27.5±0.27ms 26.6±0.30ms -3.27%
transaction_validation::validate_manifest 48.8±0.18µs 48.8±0.47µs 0.00%
transaction_validation::verify_ecdsa 85.1±0.36µs 85.1±0.58µs 0.00%
transaction_validation::verify_ed25519 60.5±0.50µs 60.6±0.48µs +0.17%

@lrubasze lrubasze merged commit b95ec28 into develop Nov 23, 2023
25 checks passed
@lrubasze lrubasze changed the title Add missing types scrypto-bindgen Add missing types to scrypto-bindgen Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants