Add workaround for inconsistent resource type schema #96
Conversation
Signed-off-by: sk593 <[email protected]>
| @@ -17,6 +17,13 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| var skippedResources = map[string]struct{}{ | |||
There was a problem hiding this comment.
We skip these files that have inconsistencies in their schema and will use older versions until we have a better fix
There was a problem hiding this comment.
Is it possible for us to dynamically detect these cases? or is that not reasonable? I'm just thinking about how we move forward.
There was a problem hiding this comment.
I think it'd be complicated but possible. Errors are only detected in the generator code with the setup we have now so we'd have to add additional processing in the downloader or generator. I'm not sure how helpful that would be since the resource schemas should ideally be returned will valid references.
The plan is to revert these changes once we get a response from the SDK team as to why the resource schemas are being returned with missing data. We should have better insight on what to do moving forward then
| @@ -17,6 +17,13 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| var skippedResources = map[string]struct{}{ | |||
There was a problem hiding this comment.
could we link the issue that caused us to disable these?
Signed-off-by: sk593 <[email protected]>
This adds a workaround to address issues in #93. There are discrepancies between the references to definitions and the actual definitions provided by the AWS resource type schema. This PR skips any files with discrepancies and uses a stable version of the schema.
An issue has been opened with the AWS SDK to investigate the discrepancy: aws/aws-sdk-go-v2#2913