Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle error in undefined property definitions #93

Closed
sk593 opened this issue Nov 25, 2024 · 1 comment
Closed

Handle error in undefined property definitions #93

sk593 opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels

Comments

@sk593
Copy link
Contributor

sk593 commented Nov 25, 2024

There's an issue in the publish-bicep.yaml workflow where properties are being referenced with no actual definition. For example, this is a referenced property but has no definition:

          "Interactions": {
            "$ref": "#/definitions/VisualInteractionOptions"
          },
An error was encountered while handling a request: Error: could not find definition #/definitions/VisualInteractionOptions in Analysis_Interactions
    at visitSchema (/home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:212:23)
    at /home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:267:34
    at Array.forEach (<anonymous>)
    at createType (/home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:266:51)
    at visitSchema (/home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:303:16)
    at /home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:167:9
    at Array.forEach (<anonymous>)
    at visitDefinitions (/home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:166:[47](https://github.com/radius-project/bicep-types-aws/actions/runs/12009498164/job/33474343787?pr=92#step:10:48))
    at visitSchemaRecord (/home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:20:5)
    at /home/runner/work/bicep-types-aws/bicep-types-aws/src/aws-type-generator/dist/src/convert.js:10:9
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);

We should see if there's an error in the download code or if this is a discrepancy with the AWS documentation

AB#13749

@sk593
Copy link
Contributor Author

sk593 commented Dec 5, 2024

Addressed by #96

@sk593 sk593 closed this as completed Dec 5, 2024
kachawla added a commit that referenced this issue Dec 6, 2024
Signed-off-by: karishma-chawla <[email protected]>
sk593 pushed a commit that referenced this issue Dec 6, 2024
Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
sk593 pushed a commit that referenced this issue Dec 12, 2024
Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
(cherry picked from commit 822a949)
sk593 pushed a commit that referenced this issue Dec 12, 2024
Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
(cherry picked from commit 822a949)
sk593 pushed a commit that referenced this issue Dec 12, 2024
Signed-off-by: karishma-chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
(cherry picked from commit 822a949)
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this issue Dec 12, 2024
(cherry picked from commit 822a949)

Signed-off-by: karishma-chawla <[email protected]>
Signed-off-by: sk593 <[email protected]>
Co-authored-by: Karishma Chawla <[email protected]>
Co-authored-by: karishma-chawla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants