Add approval workflow #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk593
had a problem deploying
to
publish-bicep
GitHub Actions
Failure
sk593
force-pushed
the
add-approval-workflow
branch
from
6ef6ea1 to
886501d
Compare
sk593
had a problem deploying
to
publish-bicep
GitHub Actions
Failure
kachawla
reviewed
Dec 12, 2024
|
|
||
| env: | ||
| # bicep-types ACR url for uploading AWS Bicep types | ||
| BICEP_TYPES_REGISTRY: 'biceptypes.azurecr.io' | ||
| AWS_REGION: us-west-2 | ||
| CI_PUBLISH_RELEASE: ${{ github.repository == 'radius-project/bicep-types-aws' && startsWith(github.ref, 'refs/tags/v') && github.event_name == 'push' }} | ||
| CI_PUBLISH_LATEST: ${{ github.repository == 'radius-project/bicep-types-aws' && github.ref == 'refs/heads/main' && github.event_name == 'push' }} | ||
| PUBLISH_BICEP_APP_ID: 1077084 |
There was a problem hiding this comment.
Do we need to document this to build shared context?
There was a problem hiding this comment.
Yes, we should. Will open a task to track
There was a problem hiding this comment.
Perfect, thanks! Could you link the issue here once it is created?
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
Signed-off-by: sk593 <[email protected]>
sk593
force-pushed
the
add-approval-workflow
branch
from
bf1fb09 to
67bd0fd
Compare
kachawla
approved these changes
Dec 13, 2024
willdavsmith
approved these changes
Jan 7, 2025
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an approval workflow to grant forks access to necessary variables to run the publish-bicep workflow. This addresses #61