-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate updating fork access #61
Comments
For Dependabot triggered PRs, we can add credentials to Dependabot to get the workflow passing. This will need to be done by a maintainer. For other forks, there are some suggestions on how to go about this. This will need further investigation as want to make sure we're not giving write access to forks. See here for details: aws-actions/configure-aws-credentials#188 Options for other forks:
|
Addressed via: #85 |
Forks and Dependabot needs access to AWS keys to run tests on opened PRs. Access should be added or we should remove setting secrets if it's not needed
Test runs from forks will fail with the following error:
Error: Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers
as a result of using this packageaws-actions/configure-aws-credentials@v4
. See this PR run for details: https://github.com/radius-project/bicep-types-aws/actions/runs/11147276332/job/30981202815?pr=62We might not need this package to configure credentials since we're pulling from CloudControl specs to generate AWS types. We should look into whether credentials are needed. If they aren't needed, we should remove this step. If they are needed, we should investigate how to give forks the correct access to run tests on PRs.
AB#13379
The text was updated successfully, but these errors were encountered: