Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

khepri_adv, khepri_tx_adv: Always return khepri_adv:many_results() #303

Merged
merged 3 commits into from
Oct 11, 2024
Merged

khepri_adv, khepri_tx_adv: Always return khepri_adv:many_results() #303

merged 3 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. khepri_adv, khepri_tx_adv: Always return khepri_adv:many_results() 

    [Why]
Functions such as `khepri_adv:get()` and `khepri_adv:put()` extracted
the single node's properties from the query/command return value and
returned only that.

Therefore, the return value had a different form than other advanced
functions' full node properties map.

In a future patch, we want to add the nodes deleted by the "expiration"
of `keep_while` conditions. They can be deleted after a delete or a put.
If we want to achieve that, we need to make all functions return the
same thing.

[How]
All functions that returned the single node props value are simplified
to return the whole map, regardless of the number of tree nodes in the
map.
    @dumbbell
    dumbbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4f6e231 View commit details
    Browse the repository at this point in the history

  2. cluster_SUITE: Fix use of projections 

    [Why]
The projection needs a tuple to insert it in ETS in the end. Therefore
we can't use the `copy` method and store an atom. We need the projection
function to create that tuple.
    @dumbbell
    dumbbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9bf22d6 View commit details
    Browse the repository at this point in the history

  3. khepri_projection: Wrap a long line

    @dumbbell
    dumbbell committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    efc491c View commit details
    Browse the repository at this point in the history