khepri_adv, khepri_tx_adv: Always return khepri_adv:many_results()
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
advanced-apis-all-return-node-props-map
branch
from
89e9807
to
c17382b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 89.66% 89.75% +0.08%
==========================================
Files 22 22
Lines 3251 3230 -21
==========================================
- Hits 2915 2899 -16
+ Misses 336 331 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the-mikedavis
approved these changes
Oct 9, 2024
dumbbell
force-pushed
the
advanced-apis-all-return-node-props-map
branch
from
c17382b
to
f71656a
Compare
[Why] Functions such as `khepri_adv:get()` and `khepri_adv:put()` extracted the single node's properties from the query/command return value and returned only that. Therefore, the return value had a different form than other advanced functions' full node properties map. In a future patch, we want to add the nodes deleted by the "expiration" of `keep_while` conditions. They can be deleted after a delete or a put. If we want to achieve that, we need to make all functions return the same thing. [How] All functions that returned the single node props value are simplified to return the whole map, regardless of the number of tree nodes in the map.
[Why] The projection needs a tuple to insert it in ETS in the end. Therefore we can't use the `copy` method and store an atom. We need the projection function to create that tuple.
dumbbell
force-pushed
the
advanced-apis-all-return-node-props-map
branch
from
f71656a
to
efc491c
Compare
Thank you! It is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Functions such as
khepri_adv:get()andkhepri_adv:put()extracted the single node's properties from the query/command return value and returned only that.Therefore, the return value had a different form than other advanced functions' full node properties map.
In a future patch, we want to add the nodes deleted by the "expiration" of
keep_whileconditions. They can be deleted after a delete or a put. If we want to achieve that, we need to make all functions return the same thing.How
All functions that returned the single node props value are simplified to return the whole map, regardless of the number of tree nodes in the map.