Prepare for CDL netlist export #1049
Conversation
|
@ra3xdh: Is there a particular reason why old Q3PtrList is used? |
The total removing of the Q3PtrList wrapper is planned. See #748 The main concern is "auto delete" feature. Some internal logic may depend on it. It requires to carefully review every occurrence of Q3PtrList. The ideas and contributions are welcome. The same for other remaining Qt3 wrappers from |
The commit name and PR name are a bit misleading. Maybe better Prepare for CDL netlist export. |
|
New title Prepare for CDL netlist export is ok for me |
|
"The main concern is "auto delete" feature." |
|
I have planned merging. I will provide a review or merge in the next week. |
|
Thanks for the info! |
|
Please resolve conflict at |
Introduced very basic c++ coding style for the extsimkernels subsystem based on https://google.github.io/styleguide/cppguide.html: -Prefix class attributes with a_ (much more better readability!) -Class member initialization via constructor member initialization list -No public class attributes Signed-off-by: ThomasZecha <[email protected]>
Introduced very basic c++ coding style for the class Schematic and it's parent-class QucsDoc based on https://google.github.io/styleguide/cppguide.html: -Prefix class attributes with a_ (much more better readability!) -Class member initialization via constructor member initialization list -No public class attributes (where possible with small effort) Signed-off-by: ThomasZecha <[email protected]>
|
Rebased and resolved conflict. |
|
Merged. |
Reviewed changes from ra3xdh#1049 SpiceLibCompDialog has been reworked to achieve the code quality improvements introduced by ra3xdh#1049. Tested the following dialogs under extsimkernel/: -ExternSimDialog -CustomSimDialog -SimSettingsDialog -SpiceLibCompDialog
Reviewed changes from ra3xdh#1049 SpiceLibCompDialog has been reworked to achieve the code quality improvements introduced by ra3xdh#1049. Tested the following dialogs under extsimkernel/: -ExternSimDialog -CustomSimDialog -SimSettingsDialog -SpiceLibCompDialog -rebased
Reviewed changes from ra3xdh#1049 SpiceLibCompDialog has been reworked to achieve the code quality improvements introduced by ra3xdh#1049. Tested the following dialogs under extsimkernel/: -ExternSimDialog -CustomSimDialog -SimSettingsDialog -SpiceLibCompDialog Rebased.
Basic introductory refactoring work for code parts affected/used by the new feature CDL netlist export (#876)
based on https://google.github.io/styleguide/cppguide.html:
-Prefix class attributes with a_ (much more better readability!)
-Class member initialization via constructor member initialization list
-No public class attributes