You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dialog window of the Spice library decice component is totally broken after #1049. Place the device on schematic and open the dialog by the double click. The following things could be noticed:
The Open button is always grayed.
The Open button near the Symbol from file switch has disappeared
I have also noticed the following problems in the code, file spicelibcompdialog.cpp.
The ´a_btnOpenLib´ is connected to wrong slot and initialized twice
It is disabled in the ´slotSelctSymbol()´
@ThomasZecha please revert the operation of this dialog. Probably is makes sense to revert the whole dialog source code to the state before #1049. Otherwise I will unmerge the #1049. Did you test the operation of the dialog after you applied the changes? I guess the #1049 may be generated using and IDE auto-refactoring features maybe with AI assistance. Please test manually every dialog/component involved in your future patches before submission.
The text was updated successfully, but these errors were encountered:
The btnOpenSymbol has disappeared from the source code in #1049. I advise to revert the dialog source. This dialog doesn't interfere the task of adding CDL netlist export feature.
#1049 was done manually step-by-step for every changed class attribute to assure 'refactoring only', but unfortunatelly something goes wrong in the initialization of the dialog object, sorry. I will do again a review and additional test of the other changed parts of the PR
The dialog window of the Spice library decice component is totally broken after #1049. Place the device on schematic and open the dialog by the double click. The following things could be noticed:
I have also noticed the following problems in the code, file
spicelibcompdialog.cpp
.@ThomasZecha please revert the operation of this dialog. Probably is makes sense to revert the whole dialog source code to the state before #1049. Otherwise I will unmerge the #1049. Did you test the operation of the dialog after you applied the changes? I guess the #1049 may be generated using and IDE auto-refactoring features maybe with AI assistance. Please test manually every dialog/component involved in your future patches before submission.
The text was updated successfully, but these errors were encountered: