Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Spice Library Device dialog totally broken after #1049 #1072

Closed
ra3xdh opened this issue Nov 18, 2024 · 4 comments · Fixed by #1073
Closed

The Spice Library Device dialog totally broken after #1049 #1072

ra3xdh opened this issue Nov 18, 2024 · 4 comments · Fixed by #1073
Labels

Comments

@ra3xdh
Copy link
Owner

ra3xdh commented Nov 18, 2024

The dialog window of the Spice library decice component is totally broken after #1049. Place the device on schematic and open the dialog by the double click. The following things could be noticed:

  • The Open button is always grayed.
  • The Open button near the Symbol from file switch has disappeared

I have also noticed the following problems in the code, file spicelibcompdialog.cpp.

  • The ´a_btnOpenLib´ is connected to wrong slot and initialized twice
  • It is disabled in the ´slotSelctSymbol()´

@ThomasZecha please revert the operation of this dialog. Probably is makes sense to revert the whole dialog source code to the state before #1049. Otherwise I will unmerge the #1049. Did you test the operation of the dialog after you applied the changes? I guess the #1049 may be generated using and IDE auto-refactoring features maybe with AI assistance. Please test manually every dialog/component involved in your future patches before submission.

image

@ra3xdh ra3xdh added the bug label Nov 18, 2024
@ra3xdh
Copy link
Owner Author

ra3xdh commented Nov 18, 2024

The btnOpenSymbol has disappeared from the source code in #1049. I advise to revert the dialog source. This dialog doesn't interfere the task of adding CDL netlist export feature.

@ThomasZecha
Copy link

I'm looking at it now

@ThomasZecha
Copy link

#1049 was done manually step-by-step for every changed class attribute to assure 'refactoring only', but unfortunatelly something goes wrong in the initialization of the dialog object, sorry. I will do again a review and additional test of the other changed parts of the PR

@ra3xdh ra3xdh linked a pull request Nov 18, 2024 that will close this issue
@ra3xdh
Copy link
Owner Author

ra3xdh commented Nov 18, 2024

Fixed by #1073. Closing as resolved.

@ra3xdh ra3xdh closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants