Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to freely add base load edsn techologies #1539

Closed

Conversation

grdw
Copy link
Contributor

@grdw grdw commented Oct 31, 2016

Fixes: #1528

@antw
Copy link
Contributor

antw commented Nov 2, 2016

This looks fine, apart from one small issue.

I'm using a copy of the staging database locally, and started to import scenario 596307 from beta ETEngine. On the technology import form (prior to actually saving the new LES), the "Households aggregated" techs were assigned the "Ameland tourist profile electricity" profile in spite of that profile being excluded from auto-assignment:

screen shot 2016-11-02 at 09 26 50

screen shot 2016-11-02 at 09 29 17

@grdw grdw force-pushed the issues/#1528-split-between-edsn-base-load-removal branch from 9fe08e2 to 5fec527 Compare November 2, 2016 10:25
@antw
Copy link
Contributor

antw commented Nov 2, 2016

Sort profiles on included in concurrency

That feels like an awkward solution. Isn't there a way to add selected="selected" to the first <option> which is permitted to be auto-selected? Now "Ameland" appears beneath "Base-load" which isn't intuitive:

screen shot 2016-11-02 at 12 10 03

@antw
Copy link
Contributor

antw commented Nov 2, 2016

Sort profiles on included in concurrency

That feels like an awkward solution.

Perhaps a nice compromise is to do something like #1459 and sort profiles into two optgroups, with included_in_concurrency being called "Featured", and everything else called "Other"?

That has the advantage of making it obvious to a visitor which profiles are official and which have been uploaded by third-parties?

+--------------------------------------+---+
| Profile                              | v |
+--------------------------------------+---+
| Featured                                 |
|   Base-load profile EDSN type E1A        |
|   Base-load profile EDSN type E1B        |
|   ...                                    |
| Other                                    |
|   Ameland tourist profile electricity    |
|   ...                                    |
+------------------------------------------+

@grdw grdw force-pushed the issues/#1528-split-between-edsn-base-load-removal branch 4 times, most recently from 0951abd to 3576c35 Compare November 25, 2016 11:13
Move the profiles that aren't included in the
concurrency to the bottom of the order.
@grdw grdw force-pushed the issues/#1528-split-between-edsn-base-load-removal branch from 3576c35 to 47d8a4d Compare November 25, 2016 11:27
@grdw grdw unassigned antw Jan 6, 2017
@grdw grdw closed this Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants