-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build-yocto: merge the check-layer job #39
Conversation
The last commit is to be discarded and was just to validate the PR |
4a2831f
to
c392e1c
Compare
Tested and dropped |
c392e1c
to
73c82d7
Compare
While this makes sense in theory, I'm not sure this will give us what we want here, as quite often there are check-layer issues not really related to this repo (e.g. poky or in meta-qcom), and with this change we won't be able to produce new builds until check-layer is green. |
73c82d7
to
468e42e
Compare
Merge this two jobs since since there are dependencies between them. They both want to use the same references in the repositories they use and need the same lock step. This will also make it possible to add interdependencies if necessary so that there are jobs A that depend on others B. Signed-off-by: Jose Quaresma <[email protected]>
468e42e
to
be5f24d
Compare
I removed the interdependence |
I also adapted the commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should run the jobs with some interdependence.
The check-layer job should be done first than the build jobs themselves
and if the first one fails, the rest will no longer be executed.
Fixes: #37