Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build-yocto: merge the check-layer job #39

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

quaresmajose
Copy link
Contributor

@quaresmajose quaresmajose commented Oct 11, 2024

We should run the jobs with some interdependence.
The check-layer job should be done first than the build jobs themselves
and if the first one fails, the rest will no longer be executed.

Fixes: #37

@quaresmajose quaresmajose requested a review from a team October 11, 2024 14:50
@quaresmajose
Copy link
Contributor Author

The last commit is to be discarded and was just to validate the PR

@quaresmajose
Copy link
Contributor Author

The last commit is to be discarded and was just to validate the PR

Tested and dropped

@quaresmajose quaresmajose marked this pull request as draft October 11, 2024 16:41
@quaresmajose quaresmajose marked this pull request as ready for review October 11, 2024 17:13
@quaresmajose quaresmajose self-assigned this Oct 11, 2024
@ricardosalveti
Copy link
Contributor

We should run the jobs with some interdependence. The check-layer job should be done first than the build jobs themselves and if the first one fails, the rest will no longer be executed.

While this makes sense in theory, I'm not sure this will give us what we want here, as quite often there are check-layer issues not really related to this repo (e.g. poky or in meta-qcom), and with this change we won't be able to produce new builds until check-layer is green.

Merge this two jobs since since there are dependencies between them.
They both want to use the same references in the repositories they use
and need the same lock step.

This will also make it possible to add interdependencies if necessary
so that there are jobs A that depend on others B.

Signed-off-by: Jose Quaresma <[email protected]>
@quaresmajose
Copy link
Contributor Author

We should run the jobs with some interdependence. The check-layer job should be done first than the build jobs themselves and if the first one fails, the rest will no longer be executed.

While this makes sense in theory, I'm not sure this will give us what we want here, as quite often there are check-layer issues not really related to this repo (e.g. poky or in meta-qcom), and with this change we won't be able to produce new builds until check-layer is green.

I removed the interdependence

@quaresmajose
Copy link
Contributor Author

I also adapted the commit

    ci: build-yocto: merge the check-layer job
    
    Merge this two jobs since since there are dependencies between them.
    They both want to use the same references in the repositories they use
    and need the same lock step.
    
    This will also make it possible to add interdependencies if necessary
    so that there are jobs A that depend on others B.

@quaresmajose quaresmajose changed the title ci: build-yocto: add dependency on check-layer job ci: build-yocto: merge the check-layer job Oct 15, 2024
Copy link
Contributor

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardosalveti ricardosalveti merged commit 84fd9b0 into qualcomm-linux:main Oct 15, 2024
6 checks passed
@quaresmajose quaresmajose deleted the build-yocto branch October 15, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Check the possibility of adding interdependence for the ci jobs
2 participants