feat: Refactor the Python API. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the functions and replace with two wrapper classes for Schema and Model. These have basic functionality to deserialise, load and run a model.
Batch21
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Had a quick look through this and I like the approach. A few observations:
- Python cli is now broken though I suspect that fixing it is already on your TODO list..
- It would be useful to add some dev dependencies to pyproject toml - pyarrow, h5py, etc..
- The piecewise-link1 test failed for me. It could not find the
mrf1/step-00component in the output h5 file.
I hadn't actually noticed this. Do we need a Rust CLI and a Python CLI? If this is staying it needs adding to the Python tests. The pipeline also needs re-enabling.
Noted!
Yes, this is why this is WIP. The test wanted to check the routing through the piecewise link. For this you need to save the sub-node timeseries. This needs support in the |
This is waiting for node attribute updates.
|
This is waiting on #85 for refactoring. |
Closed
jetuk
changed the title
The hdf5 crate is failing and I do not have access to macos to debug.
Batch21
reviewed
Jan 31, 2024
README.md
Outdated
|
|
||
| ```bash | ||
| python -m pywr | ||
| poetry install # install dependencies |
There was a problem hiding this comment.
This will no longer work with the poetry sections taken out of pyproject.toml?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the functions and replace with two wrapper classes for Schema and Model. These have basic functionality to deserialise, load and run a model.