Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python ABI3 wheels #96

Closed
jetuk opened this issue Jan 30, 2024 · 4 comments
Closed

Build Python ABI3 wheels #96

jetuk opened this issue Jan 30, 2024 · 4 comments
Labels
github_actions Pull requests that update GitHub Actions code python rust Pull requests that update Rust code

Comments

@jetuk
Copy link
Member

jetuk commented Jan 30, 2024

The updates to the Python extension in #73 are not ABI3 compatible. Building ABI3 wheels would reduce the CI to one build per platform rather requiring individual Python version wheels.

Currently this is blocked by the extension module using PyDate and PyDateAccess which are not part of the ABI. Removing these objects from the extension can be done by either:

  1. Using chrono and the support in pyo3 for converting from Python datetime objects to chrono types, or
  2. Replicating the above support but for the time crate that is currently used here. One would have to follow the same idea as for the chrono conversions in pyo3 and use the Python API directly in the extension.
@jetuk jetuk added github_actions Pull requests that update GitHub Actions code rust Pull requests that update Rust code python labels Jan 30, 2024
@jetuk
Copy link
Member Author

jetuk commented Jan 30, 2024

@jetuk
Copy link
Member Author

jetuk commented Feb 20, 2024

Once #115 is merged (1) above can be done, and we should be able to produce ABI3 wheels.

@jetuk
Copy link
Member Author

jetuk commented Feb 25, 2024

Turns out, it can't be done just yet because the features required in PyO3 haven't been released yet.

@jetuk
Copy link
Member Author

jetuk commented Apr 26, 2024

#175

@jetuk jetuk closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code python rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

1 participant