Added weekly profile

[s-simoncelli]

Hello,

I implemented the weekly profile to support 52 (like pywr 1) or 53 values. Things to address:

• The profile is implemented as Vec and not array due to the size limit of arrays
• Import from v1 not yet implemented

[jetuk]

Thanks for this.

Do we think the weekly profile should support interpolation like the monthly profile? I'm not suggesting this is done here, but if it would be a useful feature we can track it as an issue.

• The profile is implemented as Vec and not array due to the size limit of arrays

Is this true? The daily profile is implemented as a 366 valued array.

You could make the difference between the two profile lengths an enum. This would force you to match on the type.

enum WeeklyProfile {
    FiftyTwo([f64; 52]),
    FiftyThree([f64; 53]),
}

pub struct WeeklyProfileParameter {
    meta: ParameterMeta,
    values: WeeklyProfile,
}

If you do the above you could then implement the look-up function as a method on the WeeklyProfile struct, and subsequently write a unit test in the module quite easily. Something like:

impl WeeklyProfile {
    fn value(&self, date: &time::Date) -> f64 {
        let current_day = date.ordinal() as usize;
        let current_day_index = current_day - 1;

        match self {
            Self::FiftyTwo(values) => {
                if current_day >= 364 {
                    values[51]
                } else {
                    values[current_day_index / 7]
                }
            }
            Self::FiftyThree(values) => {
                if current_day >= 364 {
                    values[52]
                } else {
                    values[current_day_index / 7]
                }
            }
        }
    }
}

[jetuk]

This has still got some errors on compilation. If you need help resolving them let me know.

[s-simoncelli]

I completed the parameter. Now it also supports interpolation similarly to the MontlyProfileParameter with 52 or 53 weeks.
I also included unit tests and the documentation for the schema.

I wasn't 100% sure how to handle the conversion from Vec and I implemented From<Vec<f64>> in the WeeklyProfileSize enum.

[jetuk]

Thanks. I'll get around to reviewing this again in the next few days.

[jetuk]

This looks really good. Some comments and some changes requested. I suggest we merge this with current functionality. Then, if we want to add ISO week functionality, do that in a separate update.

Doc string is very helpful and should be a template for the others.

[jetuk]

I'll look through this again. However, I'm not sure what's happened to the commits / branch. It is now showing a lot of changes to main?

[s-simoncelli]

Hello,

I think I rebased the branch instead of merging the changes from the main. I then made the requested changes. Because it's going to be messy restoring the history, I created a clean branch here.

[jetuk]

Closing in favour of #121