Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all parameter types #14

Open
34 of 72 tasks
jetuk opened this issue Mar 6, 2023 · 2 comments
Open
34 of 72 tasks

Implement all parameter types #14

jetuk opened this issue Mar 6, 2023 · 2 comments

Comments

@jetuk
Copy link
Member

jetuk commented Mar 6, 2023

This is a tracking issue for the implementation of parameter types from Pywr v1.x.

  • Parameter (Baseclass is now a trait)
  • ConstantParameter
  • DataFrameParameter
  • ArrayIndexedParameter
  • ArrayIndexedScenarioParameter
  • TablesArrayParameter
  • ConstantScenarioParameter
  • ArrayIndexedScenarioMonthlyFactorsParameter
  • DailyProfileParameter
  • WeeklyProfileParameter (Added weekly profile #72)
  • MonthlyProfileParameter
  • ScenarioMonthlyProfileParameter
  • ScenarioWeeklyProfileParameter
  • ScenarioDailyProfileParameter
  • UniformDrawdownProfileParameter
  • RbfProfileParameter (feat: Add RbfProfileParameter #55)
  • IndexParameter (Baseclass is now a trait)
  • ConstantScenarioIndexParameter
  • IndexedArrayParameter
  • AnnualHarmonicSeriesParameter
  • AggregatedParameter
  • AggregatedIndexParameter
  • DivisionParameter
  • NegativeParameter
  • MaxParameter
  • NegativeMaxParameter (Implemented NegativeMaxParameter and NegativeMinParameter #79)
  • MinParameter
  • NegativeMinParameter (Implemented NegativeMaxParameter and NegativeMinParameter #79)
  • OffsetParameter
  • DeficitParameter (implemented via metrics)
  • FlowParameter (implemented via metrics)
  • StorageParameter (implemented via metrics)
  • PiecewiseIntegralParameter
  • FlowDelayParameter
  • DiscountFactorParameter
  • RollingMeanFlowNodeParameter
  • TimestepLicense
  • StorageLicense
  • AnnualLicense
  • AnnualExponentialLicense
  • AnnualHyperbolaLicense
  • Polynomial1DParameter
  • Polynomial2DStorageParameter
  • StorageThresholdParameter
  • NodeThresholdParameter
  • MultipleThresholdIndexParameter
  • MultipleThresholdParameterIndexParameter
  • ParameterThresholdParameter
  • RecorderThresholdParameter
  • CurrentYearThresholdParameter
  • CurrentOrdinalDayThresholdParameter
  • HydropowerTargetParameter
  • BinaryStepParameter (feat: Initial commit of variable API. #32 integrated into ConstantParameter)
  • RectifierParameter (feat: Initial commit of variable API. #32 integrated into ConstantParameter)
  • LogisticParameter (feat: Initial commit of variable API. #32 integrated into ConstantParameter)
  • BaseControlCurveParameter (Baseclass not required)
  • ControlCurveInterpolatedParameter
  • ControlCurvePiecewiseInterpolatedParameter
  • ControlCurveIndexParameter
  • ControlCurveParameter
  • WeightedAverageProfileParameter
  • OtherModelParameterValueParameter (new multi-model implementation feat: Add support for multi-model simulation. #60)
  • OtherModelIndexParameterValueIndexParameter (new multi-model implementation feat: Add support for multi-model simulation. #60)
  • OtherModelNodeFlowParameter (new multi-model implementation feat: Add support for multi-model simulation. #60)
  • OtherModelNodeStorageParameter (new multi-model implementation feat: Add support for multi-model simulation. #60)
  • FunctionParameter
  • ScaledProfileParameter
  • InterpolatedParameter
  • InterpolatedVolumeParameter
  • InterpolatedFlowParameter
  • InterpolatedQuadratureParameter
  • ScenarioWrapperParameter
@s-simoncelli
Copy link
Contributor

Hello,

I started to look at implementing DeficitParameter, FlowParameter and StorageParameter but I noticed that these have been marked as deprecated in the repo code because metrics can be used. Does this mean we can tick them off?

@jetuk
Copy link
Member Author

jetuk commented Dec 19, 2023

Yes. I will do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants