Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reader for OSI SAF L3 products #2632
Add reader for OSI SAF L3 products #2632
Changes from 3 commits
3cbc702
300a9a1
13fffa6
ac08013
23db54b
aef8d90
89d6b64
35196b6
fd0ce95
bff527e
7f81773
c450ad5
cd864e3
fd704fe
e2ecf95
c7b3bab
00df29f
5d6bbd9
98061ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 55 in satpy/readers/osisaf_l3_nc.py
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why swallow the
KeyError
s? Wouldn't that hide bugs elsewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because various versions of the files have different key names, so I have to try multiple attempts. Some of them don't have the attr at all - hence hiding the error. Would you prefer if I added a log warning or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the main way this is used is to try multiple possible attribute/variable names, then maybe a different version of this with a for loop would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully my newest change is suitable. If not, I'll come back to it some time in the new year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same thing:
satpy/satpy/readers/netcdf_utils.py
Lines 346 to 351 in 6fb1d1e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err, apparently yes! Removed.
Check warning on line 144 in satpy/readers/osisaf_l3_nc.py
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method