Add reader for OSI SAF L3 products #2632
Merged
This check has been archived and is scheduled for deletion.
Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Nov 8, 2023 in 35s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication osisaf_l3_nc.py
- Code Duplication test_osisaf_l3.py
- Complex Method osisaf_l3_nc.py: OSISAFL3NCFileHandler.get_dataset
Annotations
Check warning on line 55 in satpy/readers/osisaf_l3_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: OSISAFL3NCFileHandler._get_ease_grid,OSISAFL3NCFileHandler._get_polar_stereographic_grid. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check warning on line 144 in satpy/readers/osisaf_l3_nc.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
OSISAFL3NCFileHandler.get_dataset has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 199 in satpy/tests/reader_tests/test_osisaf_l3.py
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: TestOSISAFL3Reader.test_get_area_def_ease,TestOSISAFL3Reader.test_get_area_def_stere. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading