gh-93453: Make get_event_loop() an alias of get_running_loop() #93454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
asyncio-get_event_loop
branch
from
17d5cad to
64dcf5b
Compare
|
Yury and myself are getting together tomorrow to discuss a bunch of pressing asyncio issues (many orphaned since Andrew and Yury stopped participating). |
gvanrossum
reviewed
Oct 6, 2022
There was a problem hiding this comment.
I think we should eventually do this, but I'm not keen to do it right now. I think we should first deprecate policies, child watchers, and set_event_loop(). See GH-94597.
| _c_get_event_loop = get_event_loop | ||
| _c__get_event_loop = _get_event_loop | ||
|
|
||
| get_event_loop = get_running_loop |
There was a problem hiding this comment.
Isn't this a duplicate of line 778?
|
I think we've changed our mind on this, and we're not doing this, ever, right? So then it should be closed. |
|
I thought that I closed this PR. Thank you for a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93453