Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94174: asyncio.get_event_loop() fails if no current event loop #94175

Closed
wants to merge 1 commit into from
Closed

gh-94174: asyncio.get_event_loop() fails if no current event loop #94175

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 23, 2022

asyncio.get_event_loop() now fails if there is no current event loop.
In Python 3.10, it emits a DeprecationWarning in this case.

asyncio.get_event_loop() now fails if there is no current event loop.
In Python 3.10, it emits a DeprecationWarning in this case.
@vstinner vstinner marked this pull request as ready for review June 23, 2022 14:13
@vstinner vstinner requested review from 1st1 and asvetlov as code owners June 23, 2022 14:13
@vstinner
Copy link
Member Author

Maybe the 2 modified tests can now be modified, I'm not sure if it's relevent to still tests all these cases, I'm not an asyncio expert. In case of doubt, I kept the tests :-)

The C implementation doesn't mention the thread name in the error message: same than _asyncio.get_running_loop().

@vstinner
Copy link
Member Author

@serhiy-storchaka
Copy link
Member

How is it failed? #93454 has not be merged yet.

@vstinner
Copy link
Member Author

vstinner commented Nov 4, 2022

I give up on this issue. I didn't take the best approach, and @serhiy-storchaka already has PR #93454 which is in good shape. Let's continue the effort on PR #93454.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants