(CAT-1807) Remove analytics from the PDK #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1339 +/- ##
==========================================
- Coverage 88.51% 87.81% -0.70%
==========================================
Files 133 129 -4
Lines 5666 5489 -177
==========================================
- Hits 5015 4820 -195
- Misses 651 669 +18 ☔ View full report in Codecov by Sentry. |
david22swan
force-pushed
the
CAT-1807/main/remove_analytics
branch
2 times, most recently
from
12744db to
811449b
Compare
david22swan
force-pushed
the
CAT-1807/main/remove_analytics
branch
from
811449b to
9a2a96f
Compare
Note: This is expected to cause failures across the entirety of the test base, these will be corrected in following commits.
david22swan
force-pushed
the
CAT-1807/main/remove_analytics
branch
from
9a2a96f to
9cd13b2
Compare
Includes correct to `lib/pdk/template.rb` Incorrect value had been set to be yielded
david22swan
force-pushed
the
CAT-1807/main/remove_analytics
branch
2 times, most recently
from
a31c7ff to
20c05ed
Compare
david22swan
force-pushed
the
CAT-1807/main/remove_analytics
branch
from
20c05ed to
34c1840
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to issues with the analytics within the PDK, the decision has been made that the time has come for them to be removed.
Checklist