(CAT-1807) Remove all reference of analytics from the unit tests

spec/spec_helper.rb

@@ -27,8 +27,6 @@
 # automatically load any shared examples or contexts
 Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
-analytics_config = nil
-
 FIXTURES_DIR = File.join(__dir__, 'fixtures')
 EMPTY_MODULE_ROOT = File.join(FIXTURES_DIR, 'module_root')
 
@@ -40,39 +38,20 @@
   end
 end
 
-RSpec.shared_context 'stubbed analytics' do
-  let(:analytics) { PDK::Analytics::Client::Noop.new(logger: logger) }
-
-  before do |example|
-    allow(PDK).to receive(:analytics).and_return(analytics) if example.metadata[:use_stubbed_analytics]
-  end
-end
-
 RSpec.configure do |c|
   c.define_derived_metadata do |metadata|
     metadata[:use_stubbed_logger] = true unless metadata.key?(:use_stubbed_logger)
-    metadata[:use_stubbed_analytics] = true unless metadata.key?(:use_stubbed_analytics)
   end
 
   c.include_context 'stubbed logger'
-  c.include_context 'stubbed analytics'
 
   c.before(:suite) do
     require 'yaml'
-    analytics_config = Tempfile.new('analytics.yml')
-    analytics_config.write(YAML.dump(disabled: true))
-    analytics_config.close
-    ENV['PDK_ANALYTICS_CONFIG'] = analytics_config.path
-  end
-
-  c.after(:suite) do
-    analytics_config.unlink
   end
 
   # This should catch any tests where we are not mocking out the actual calls to Rubygems.org
   c.before do
     allow(Gem::SpecFetcher).to receive(:fetcher).and_raise('Unmocked call to Gem::SpecFetcher.fetcher!')
-    ENV['PDK_DISABLE_ANALYTICS'] = 'true'
   end
 
   c.add_setting :root

spec/support/mock_configuration.rb

@@ -1,10 +1,8 @@
 RSpec.shared_context 'mock configuration' do
   let(:default_answer_file_content) { nil }
   let(:system_answers_content) { nil }
-  let(:analytics_config_content) { nil }
   let(:user_config_content) { nil }
   let(:system_config_content) { nil }
-  let(:bolt_analytics_content) { nil }
 
   let(:new_config) do
     PDK::Config.new.tap do |item|
@@ -23,10 +21,8 @@
     [
       { file: PDK::AnswerFile.default_answer_file_path, content: default_answer_file_content },
       { file: PDK::Config.system_answers_path, content: system_answers_content },
-      { file: PDK::Config.analytics_config_path, content: analytics_config_content },
       { file: PDK::Config.user_config_path, content: user_config_content },
-      { file: PDK::Config.system_config_path, content: system_config_content },
-      { file: '~/.puppetlabs/bolt/analytics.yaml', content: bolt_analytics_content }
+      { file: PDK::Config.system_config_path, content: system_config_content }
     ].each do |item|
       # If the content is nil then mock a missing file, otherwise mock a read-able file
       if item[:content].nil?