Ensure CNI manifest is applied to cluster when the base manifest and provider are updated #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
force-pushed
the
rquitales/always-apply-cni
branch
from
9548c72 to
64edbb6
Compare
rquitales
force-pushed
the
rquitales/always-apply-cni
branch
from
64edbb6 to
a1bb000
Compare
rquitales
force-pushed
the
rquitales/always-apply-cni
branch
from
a1bb000 to
4ef5be6
Compare
thomas11
approved these changes
Mar 26, 2024
Recording fresh test snapshots for `TestExamplesUpgrade`.
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
force-pushed
the
rquitales/always-apply-cni
branch
from
75e57a5 to
de518b3
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
…provider are updated (#1093) ### Proposed changes This PR ensures that changes to the base CNI manifest is applied as a Pulumi update whenever the provider version changes. This is done by now also storing the computed manifest in state to diff against. Previously, only changes to user VpcCni opts caused a diff. This would mean that some users who have already updated to the latest provider version, and manually triggered a CNI update would encounter a one-off spurious diff since the computed manifest would not have been stored in state. Changes made: - Add applied manifest to state to fix the issue where the manifest isn't reapplied when the provider is updated - fix the issue where VpcCni could not be passed a kubeconfig object correctly - updated CI to use the latest version of the Pulumi binary - Added CNIAcrossUpdates integration test - Added CNIAcrossUpdates to the list of tests to run in CI ### Related issues (optional) Fixes: #1057 Fixes: #1092 --------- Co-authored-by: Pulumi Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR ensures that changes to the base CNI manifest is applied as a Pulumi update whenever the provider version changes. This is done by now also storing the computed manifest in state to diff against. Previously, only changes to user VpcCni opts caused a diff. This would mean that some users who have already updated to the latest provider version, and manually triggered a CNI update would encounter a one-off spurious diff since the computed manifest would not have been stored in state.
Changes made:
Related issues (optional)
Fixes: #1057
Fixes: #1092