Allow setting custom nodeagent container images #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
force-pushed
the
rquitales/additional-image
branch
from
fb92924 to
7689fd2
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
commented
Mar 26, 2024
| @@ -137,7 +149,10 @@ function computeVpcCniYaml(cniYamlText: string, args: VpcCniInputs): string { | |||
| env.push({ name: "AWS_VPC_ENI_MTU", value: "9001" }); | |||
| } | |||
| if (args.image) { | |||
| daemonSet.spec.template.spec.containers[0].image = args.image.toString(); | |||
There was a problem hiding this comment.
note: previously the logic depended on the ordering of containers which is error-prone. I've updated the code to do a scan instead.
rquitales
force-pushed
the
rquitales/additional-image
branch
from
7689fd2 to
17a4044
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
changed the title
rquitales
force-pushed
the
rquitales/additional-image
branch
from
17a4044 to
3f5f083
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
thomas11
approved these changes
Mar 27, 2024
rquitales
force-pushed
the
rquitales/additional-image
branch
from
3f5f083 to
457310b
Compare
rquitales
force-pushed
the
rquitales/additional-image
branch
from
457310b to
901c517
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
pushed a commit
that referenced
this pull request
Sep 4, 2024
### Proposed changes This PR exposes an additional option for `VpcCni` resources. The `nodeImage` option will allow users to specify a custom `aws-eks-nodeagent` container image. #### Changes made: - Added logic to enable customizing nodeagent container images - Added jest unit test to validate images can be set - Exposed the `nodeImage` option as a customizable argument in schema - Rebuilt SDKs ### Related issues (optional) Fixes: #1078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR exposes an additional option for
VpcCniresources. ThenodeImageoption will allow users to specify a customaws-eks-nodeagentcontainer image.Changes made:
nodeImageoption as a customizable argument in schemaRelated issues (optional)
Fixes: #1078