chore: disable running waf upstream tests
#5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are hitting quota limitations such as:
=== NAME TestAccWAFRuleGroup_changeNameForceNew
rule_group_test.go:75: Step 1/3 error: Error running apply: exit status 1
Error: creating WAF Rule Group (tfaccyzotq): operation error WAF: CreateRuleGroup, https response error StatusCode: 400, RequestID: fcb7db05-54ed-4ab1-8a3b-cecdb02574fb, WAFLimitsExceededException: Operation would result in exceeding resource limits.
with aws_waf_rule_group.test,
on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group" "test":
17: resource "aws_waf_rule_group" "test" {
The intent of these tests was to smoke-test the upstream provider post-patching. However it appears that instead of
smoke-testing the `wafv2` module that was patched the older `waf` module is being smoke-tested which might have stricter
quotas. Removing for now.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5001 +/- ##
=======================================
Coverage 24.42% 24.42%
=======================================
Files 360 360
Lines 143403 143403
=======================================
Hits 35023 35023
Misses 108281 108281
Partials 99 99 ☔ View full report in Codecov by Sentry. |
corymhall
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are hitting quota limitations such as:
The intent of these tests was to smoke-test the upstream provider post-patching. However it appears that instead of smoke-testing the
wafv2module that was patched the olderwafmodule is being smoke-tested which might have stricter quotas. Removing for now.