Skip to content

Commit

Permalink
chore: disable running waf upstream tests (#5001)
Browse files Browse the repository at this point in the history
These tests are hitting quota limitations such as:

        === NAME  TestAccWAFRuleGroup_changeNameForceNew
rule_group_test.go:75: Step 1/3 error: Error running apply: exit status
1

Error: creating WAF Rule Group (tfaccyzotq): operation error WAF:
CreateRuleGroup, https response error StatusCode: 400, RequestID:
fcb7db05-54ed-4ab1-8a3b-cecdb02574fb, WAFLimitsExceededException:
Operation would result in exceeding resource limits.

                  with aws_waf_rule_group.test,
on terraform_plugin_test.tf line 17, in resource "aws_waf_rule_group"
"test":
                  17: resource "aws_waf_rule_group" "test" {

The intent of these tests was to smoke-test the upstream provider
post-patching. However it appears that instead of smoke-testing the
`wafv2` module that was patched the older `waf` module is being
smoke-tested which might have stricter quotas. Removing for now.
  • Loading branch information
t0yv0 authored Dec 23, 2024
1 parent 8b981bc commit 5037c71
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/aws-upstream-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
matrix:
service:
- sqs
- waf
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down

0 comments on commit 5037c71

Please sign in to comment.