Upstream v5.67.0 #4458

t0yv0 · 2024-09-13T17:36:52Z

This change upgrades upstream to v5.67.0.

Fixes #4435
Fixes #4454

v5.66.0 changes:

Notable upstream additions:

New resources:

datazone/environment.Environment

New functions:

glue/getRegistry.getRegistry
organizations/....getOrganizationalUnitDescendantOrganizationalUnits
quicksight/getAnalysis.getAnalysis
quicksight/getQuicksightAnalysis.getQuicksightAnalysis

Unfortunately the aws_quicksight_analysis datasource cannot yet be fully supported in the provider because excessively large type hierarchies in Quicksight cause issues for Pulumi SDKs. This is the same problem that makes "definition" fields unavailable for Quicksight resources. A solution is being explored in #4449 but in the meantime the "definition" field is not available yet in Pulumi for the given datasource.

There also was a regression hashicorp/terraform-provider-aws#39320 in v5.66.0 that tripped pulumi-aws testing so the matching pulumi-aws release is skipped.

v5.67.0 changes:

cloudformation/stackInstances.StackInstances
codebuild/fleet.Fleet
computeoptimizer/enrollmentStatus.EnrollmentStatus
computeoptimizer/recommendationPreferences.RecommendationPreferences
costoptimizationhub/enrollmentStatus.EnrollmentStatus
costoptimizationhub/preferences.Preferences
datazone/assetType.AssetType
lambda/functionRecursionConfig.FunctionRecursionConfig

New functions:

codebuild/getFleet.getFleet

Unfortunately one of the upstream features that introduced support for IAM role chaining is projecting as a breaking change to Pulumi types. Since our policy is to prioritize backwards compatibility, this feature has been backed out and is not yet available in the upcoming pulumi-aws release.

See: hashicorp/terraform-provider-aws#22728

Reminder opened to track this in #4459

github-actions · 2024-09-13T18:09:48Z

Does the PR have any schema changes?

Found 6 breaking changes:

Resources

🟢 "aws:rolesanywhere/profile:Profile": required: "roleArns" property is no longer Required

Functions

🟡 "aws:quicksight/getDataSet:getDataSet": inputs: "columnLevelPermissionRules" missing input "columnLevelPermissionRules"

Types

🟢 "aws:appconfig/ExtensionActionPointAction:ExtensionActionPointAction": required: "roleArn" property is no longer Required
🟡 "aws:lex/V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting:V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting": properties: "audioRecognitionSetting" missing
🟡 "aws:networkmanager/getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride:getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride": properties: "edgeSets": items type changed from "string" to "array":
- 🟡 items had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}

New resources:

cloudformation/stackInstances.StackInstances
codebuild/fleet.Fleet
computeoptimizer/enrollmentStatus.EnrollmentStatus
computeoptimizer/recommendationPreferences.RecommendationPreferences
costoptimizationhub/enrollmentStatus.EnrollmentStatus
costoptimizationhub/preferences.Preferences
datazone/assetType.AssetType
datazone/environment.Environment
lambda/functionRecursionConfig.FunctionRecursionConfig

New functions:

codebuild/getFleet.getFleet
glue/getRegistry.getRegistry
organizations/getOrganizationalUnitDescendantOrganizationalUnits.getOrganizationalUnitDescendantOrganizationalUnits
quicksight/getAnalysis.getAnalysis
quicksight/getQuicksightAnalysis.getQuicksightAnalysis

Maintainer note: consult the runbook for dealing with any breaking changes.

t0yv0 · 2024-09-13T19:36:54Z

Looks like assumeRole is now assumeRoles (plural), which is a breaking change for Pulumi. Looking at options quickly.

SError: ⨯ Unable to compile TypeScript:
Error: index.ts(28,5): error TS2345: Argument of type '{ assumeRole: { roleArn: pulumi.Output<string>; }; }' is not assignable to parameter of type 'ProviderArgs'.
  Object literal may only specify known properties, but 'assumeRole' does not exist in type 'ProviderArgs'. Did you mean to write 'assumeRoles'?

t0yv0 · 2024-09-13T19:39:37Z

Coming from here: hashicorp/terraform-provider-aws@faa9b8e

flostadler

This was a wild ride! Good job!

flostadler · 2024-09-16T11:30:30Z

patches/0037-Restore-legacy-bucket.patch

@@ -5,319 +5,508 @@ Subject: [PATCH] Restore legacy bucket


 diff --git a/go.mod b/go.mod
-index 0d8ccda18d..85b3de0453 100644
+index 5b8c85d7d3..a145fa7f16 100644


This patch diff is hard to review. Couldn't spot anything wrong though

We should probably take upstream/go.mod churn out of patches and try to see if we can accept the unmodified upstream go.mod.

pulumi-bot · 2024-09-16T19:16:13Z

This PR has been shipped in release v6.52.0.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://redirect.github.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.51.1` -> `6.52.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.51.1/6.52.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.52.0`](https://redirect.github.com/pulumi/pulumi-aws/releases/tag/v6.52.0) [Compare Source](https://redirect.github.com/pulumi/pulumi-aws/compare/v6.51.1...v6.52.0) ##### Does the PR have any schema changes? Found 6 breaking changes: ##### Resources - `🟢` "aws:rolesanywhere/profile:Profile": required: "roleArns" property is no longer Required ##### Functions - `🟡` "aws:quicksight/getDataSet:getDataSet": inputs: "columnLevelPermissionRules" missing input "columnLevelPermissionRules" ##### Types - `🟢` "aws:appconfig/ExtensionActionPointAction:ExtensionActionPointAction": required: "roleArn" property is no longer Required - `🟡` "aws:lex/V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting:V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting": properties: "audioRecognitionSetting" missing - `🟡` "aws:networkmanager/getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride:getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride": properties: "edgeSets": items type changed from "string" to "array": - `🟡` items had no type but now has &{Type:string Ref: AdditionalProperties:<nil> Items:<nil> OneOf:\[] Discriminator:<nil> Plain:false} ##### New resources: - `cloudformation/stackInstances.StackInstances` - `codebuild/fleet.Fleet` - `computeoptimizer/enrollmentStatus.EnrollmentStatus` - `computeoptimizer/recommendationPreferences.RecommendationPreferences` - `costoptimizationhub/enrollmentStatus.EnrollmentStatus` - `costoptimizationhub/preferences.Preferences` - `datazone/assetType.AssetType` - `datazone/environment.Environment` - `lambda/functionRecursionConfig.FunctionRecursionConfig` ##### New functions: - `codebuild/getFleet.getFleet` - `glue/getRegistry.getRegistry` - `organizations/getOrganizationalUnitDescendantOrganizationalUnits.getOrganizationalUnitDescendantOrganizationalUnits` - `quicksight/getAnalysis.getAnalysis` - `quicksight/getQuicksightAnalysis.getQuicksightAnalysis` ##### What's Changed - Update GitHub Actions workflows. by [@pulumi-bot](https://redirect.github.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4456](https://redirect.github.com/pulumi/pulumi-aws/pull/4456) - Update GitHub Actions workflows. by [@pulumi-bot](https://redirect.github.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4464](https://redirect.github.com/pulumi/pulumi-aws/pull/4464) - Upstream v5.67.0 by [@t0yv0](https://redirect.github.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4458](https://redirect.github.com/pulumi/pulumi-aws/pull/4458) **Full Changelog**: pulumi/pulumi-aws@v6.51.1...v6.52.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/aws](https://pulumi.io) ([source](https://redirect.github.com/pulumi/pulumi-aws)) | dependencies | minor | [`6.51.1` -> `6.52.0`](https://renovatebot.com/diffs/npm/@pulumi%2faws/6.51.1/6.52.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-aws (@pulumi/aws)</summary> ### [`v6.52.0`](https://redirect.github.com/pulumi/pulumi-aws/releases/tag/v6.52.0) [Compare Source](https://redirect.github.com/pulumi/pulumi-aws/compare/v6.51.1...v6.52.0) ##### Does the PR have any schema changes? Found 6 breaking changes: ##### Resources - `🟢` "aws:rolesanywhere/profile:Profile": required: "roleArns" property is no longer Required ##### Functions - `🟡` "aws:quicksight/getDataSet:getDataSet": inputs: "columnLevelPermissionRules" missing input "columnLevelPermissionRules" ##### Types - `🟢` "aws:appconfig/ExtensionActionPointAction:ExtensionActionPointAction": required: "roleArn" property is no longer Required - `🟡` "aws:lex/V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting:V2modelsSlotTypeValueSelectionSettingAdvancedRecognitionSetting": properties: "audioRecognitionSetting" missing - `🟡` "aws:networkmanager/getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride:getCoreNetworkPolicyDocumentSegmentActionViaWithEdgeOverride": properties: "edgeSets": items type changed from "string" to "array": - `🟡` items had no type but now has &{Type:string Ref: AdditionalProperties:<nil> Items:<nil> OneOf:\[] Discriminator:<nil> Plain:false} ##### New resources: - `cloudformation/stackInstances.StackInstances` - `codebuild/fleet.Fleet` - `computeoptimizer/enrollmentStatus.EnrollmentStatus` - `computeoptimizer/recommendationPreferences.RecommendationPreferences` - `costoptimizationhub/enrollmentStatus.EnrollmentStatus` - `costoptimizationhub/preferences.Preferences` - `datazone/assetType.AssetType` - `datazone/environment.Environment` - `lambda/functionRecursionConfig.FunctionRecursionConfig` ##### New functions: - `codebuild/getFleet.getFleet` - `glue/getRegistry.getRegistry` - `organizations/getOrganizationalUnitDescendantOrganizationalUnits.getOrganizationalUnitDescendantOrganizationalUnits` - `quicksight/getAnalysis.getAnalysis` - `quicksight/getQuicksightAnalysis.getQuicksightAnalysis` ##### What's Changed - Update GitHub Actions workflows. by [@pulumi-bot](https://redirect.github.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4456](https://redirect.github.com/pulumi/pulumi-aws/pull/4456) - Update GitHub Actions workflows. by [@pulumi-bot](https://redirect.github.com/pulumi-bot) in [https://github.com/pulumi/pulumi-aws/pull/4464](https://redirect.github.com/pulumi/pulumi-aws/pull/4464) - Upstream v5.67.0 by [@t0yv0](https://redirect.github.com/t0yv0) in [https://github.com/pulumi/pulumi-aws/pull/4458](https://redirect.github.com/pulumi/pulumi-aws/pull/4458) **Full Changelog**: pulumi/pulumi-aws@v6.51.1...v6.52.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

t0yv0 added 17 commits September 12, 2024 23:19

Update patches for v5.66.0

858c787

Move upstream to v5.66.0

d575afd

./scripts/tidy-all.sh

d0d8aca

Update bridge to use token shortening feature

0ff2f55

Workaround Quicksight Definition type explosion problem

dc4e36b

make tfgen

05b2cb6

make build_sdks

6d88425

Revert bridge customization

5f5c81f

Revert examples/go.mod updates

f577e2a

Update patches for v5.67.0

492aad9

Move upstream to v5.67.0

8f9eaee

./scripts/tidy-all.sh

3d7e94b

Accommodate AssumeRole type changes

bf1f2c9

Name new missing modules

efc4176

Fill out missing IDs

3241eda

make tfgen

3e09f82

make build_sdk

0da0dca

t0yv0 requested a review from flostadler September 13, 2024 17:37

t0yv0 mentioned this pull request Sep 13, 2024

Upstream v5.66.0 #4455

Closed

t0yv0 mentioned this pull request Sep 13, 2024

Breaking configuration changes are not detected pulumi/schema-tools#74

Open

t0yv0 added 3 commits September 13, 2024 16:03

Retain assumeRole for backwards compat

a3a294d

make tfgen

bff9f9f

make build_sdks

e0d43ab

t0yv0 requested a review from corymhall September 13, 2024 21:52

t0yv0 marked this pull request as ready for review September 13, 2024 21:52

mjeffryes assigned t0yv0 Sep 13, 2024

flostadler approved these changes Sep 16, 2024

View reviewed changes

corymhall approved these changes Sep 16, 2024

View reviewed changes

t0yv0 merged commit f4af80f into master Sep 16, 2024
30 checks passed

t0yv0 deleted the upstream-v5.67.0 branch September 16, 2024 13:23

This was referenced Sep 16, 2024

Upgrade terraform-provider-aws to v5.66.0 #4435

Closed

Upgrade terraform-provider-aws to v5.67.0 #4454

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upstream v5.67.0 #4458

Upstream v5.67.0 #4458

t0yv0 commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading

t0yv0 commented Sep 13, 2024

t0yv0 commented Sep 13, 2024

flostadler left a comment

flostadler Sep 16, 2024

t0yv0 Sep 16, 2024

t0yv0 Sep 16, 2024

pulumi-bot commented Sep 16, 2024

Upstream v5.67.0 #4458

Upstream v5.67.0 #4458

Conversation

t0yv0 commented Sep 13, 2024 • edited Loading

github-actions bot commented Sep 13, 2024 • edited Loading

Does the PR have any schema changes?

Resources

Functions

Types

New resources:

New functions:

t0yv0 commented Sep 13, 2024

t0yv0 commented Sep 13, 2024

flostadler left a comment

Choose a reason for hiding this comment

flostadler Sep 16, 2024

Choose a reason for hiding this comment

t0yv0 Sep 16, 2024

Choose a reason for hiding this comment

t0yv0 Sep 16, 2024

Choose a reason for hiding this comment

pulumi-bot commented Sep 16, 2024

t0yv0 commented Sep 13, 2024 •

edited

Loading

github-actions bot commented Sep 13, 2024 •

edited

Loading