Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking configuration changes are not detected #74

Open
t0yv0 opened this issue Sep 13, 2024 · 1 comment
Open

Breaking configuration changes are not detected #74

t0yv0 opened this issue Sep 13, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented Sep 13, 2024

What happened?

It would be nice to detect changes in the provider configuration space.

Example

pulumi/pulumi-aws#4458

Upstream AWS introduced a change that's breaking in Pulumi, where assumeRole becomes assumeRoles: List in the provider configuration. This was not surfaced by the schema-tools report.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 13, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Sep 13, 2024

My apologies, looks like it's detected in the type space. Just it's not highlighted as prominently and is listed together with "etc types". I think just a nice to have here to highlight changes to provider configuration that are breaking. At least it's red which is great.

🔴 "aws:config/assumeRole:assumeRole" missing

@mjeffryes mjeffryes added kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants