Require local provider in tests #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
changed the base branch from
master
to
vvm/run_credentials_validation_only_once
VenelinMartinov
changed the title
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
reviewed
Nov 3, 2023
t0yv0
reviewed
Nov 3, 2023
danielrbradley
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Yup, nice this is a good stop-gap while we still use the $PATH.
The long term aim here is to ditch ever relying on the $PATH and rather use either:
- Starting the provider first then connecting the test to the running provider via
PULUMI_DEBUG_PROVIDERS. - Using the plugin configuration section of the
Pulumi.yamlto specify where to run the provider from.
Either of these approaches is preferred in the long term as their failure mode is more predictable - if the explicitly specified provider is not found, then the whole run immediately fails as we can also disable using ambient providers.
Base automatically changed from
vvm/run_credentials_validation_only_once
to
master
November 3, 2023 21:36
t0yv0
reviewed
Nov 14, 2023
t0yv0
reviewed
Nov 14, 2023
VenelinMartinov
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Nov 15, 2023
This PR adds a new make target for providers `provider_no_deps` - this one will just run the go build command without `tfgen` and `install_plugins`. This is needed since `tfgen` and `install_plugins` have no caching, so will rerun each time and I'd like to use the `go build` in pulumi/pulumi-aws#2953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test main for the aws provider which checks that the aws provider used in the tests is a local one.
The default behaviour is for the pulumi binary to download a provider which leads to some quite confusing behaviour.