Disable provider building in tests #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to consider not add any new complexity here but simply adjust the Go logic as appropriate? You could detect that the provider binary is in PATH by os.LookExec or you could detect that the code is in CI context by examining environment variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to disable the new behaviour that will be added in pulumi/pulumi-aws#2953 for CI.
pulumi/pulumi-aws#2953 will add provider building as a prerequisite of running tests, which is great for local development but is not what we want for CI, since it has a separate job for building the provider.
We set the env var
DISABLE_PROVIDER_BUILDto disable the builds in CI.