Skip to content

Commit

Permalink
Remove unused npm dependencies
Browse files Browse the repository at this point in the history
It looks like `resolve` and `builtin-modules` dependencies aren't actually used anywhere, so stop depending on them.

The motivation for this change is that the dependency on `resolve` causes errors to be logged in logs during plugin discovery, because the package includes its tests that have malformed `package.json` files in its package. If we don't actually need the dependency, it'd be nice to remove it so those errors are no longer logged (so users don't have to ask us about them).

Also remove the `builtin-modules` dependency while cleaning this up, since it doesn't appear to be used either AFAICT.
  • Loading branch information
justinvp committed Dec 23, 2024
1 parent 5037c71 commit 735e0e8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions provider/cmd/pulumi-resource-aws/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,7 @@
"packageDescription": "A Pulumi package for creating and managing Amazon Web Services (AWS) cloud resources.",
"readme": "\u003e This provider is a derived work of the [Terraform Provider](https://github.com/hashicorp/terraform-provider-aws)\n\u003e distributed under [MPL 2.0](https://www.mozilla.org/en-US/MPL/2.0/). If you encounter a bug or missing feature,\n\u003e first check the [`pulumi-aws` repo](https://github.com/pulumi/pulumi-aws/issues); however, if that doesn't turn up anything,\n\u003e please consult the source [`terraform-provider-aws` repo](https://github.com/hashicorp/terraform-provider-aws/issues).",
"dependencies": {
"builtin-modules": "3.0.0",
"mime": "^2.0.0",
"resolve": "^1.7.1"
"mime": "^2.0.0"
},
"devDependencies": {
"@types/mime": "^2.0.0",
Expand Down
4 changes: 1 addition & 3 deletions provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -5275,9 +5275,7 @@ compatibility shim in favor of the new "name" field.`)
},
JavaScript: &tfbridge.JavaScriptInfo{
Dependencies: map[string]string{
"mime": "^2.0.0",
"builtin-modules": "3.0.0",
"resolve": "^1.7.1",
"mime": "^2.0.0",
},
DevDependencies: map[string]string{
"@types/node": "^10.0.0", // so we can access strongly typed node definitions.
Expand Down
4 changes: 1 addition & 3 deletions sdk/nodejs/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 735e0e8

Please sign in to comment.