Use upstream csi-cloudscale Helm chart #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/use-helmchart
branch
from
54df1bf to
b285349
Compare
simu
force-pushed
the
feat/use-helmchart
branch
from
b285349 to
77ac4cd
Compare
simu
changed the title
simu
force-pushed
the
feat/use-helmchart
branch
2 times, most recently
from
c780bb7 to
0c98250
Compare
…tions` parameter We can't simply pass the parameter to the `node.tolerations` Helm value, since that value expects an array of regular tolerations while the component parameter is structured to allow users to overwrite tolerations. Note that the postprocessing filter will retain tolerations configured through the Helm value and will simply append any tolerations configured in `driver_daemonset_tolerations`.
simu
force-pushed
the
feat/use-helmchart
branch
from
0c98250 to
3e95d46
Compare
|
The only actual change is that the |
We don't need it ourselves since we don't use parameter `version` anywhere.
simu
force-pushed
the
feat/use-helmchart
branch
from
64dedd8 to
35ddf74
Compare
DebakelOrakel
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, as we remove component parameter
version.TODO
driver_daemonset_tolerationsis not respected by the PR yetChecklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.