Remove parameter enabled
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megian
force-pushed
the
remove-enable-flag
branch
from
5fee187 to
d3f4093
Compare
simu
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
I agree that this shouldn't be required anymore, but please note that there's still combinations where the native support to remove components doesn't work as expected (e.g. removing the component at distribution level, when it's included at cloud provider level with the hierarchy we use internally).
|
Keeping this PR unmerged, until commodore has been improved. |
The functionality to disable specific components has been introduced in commodore.
simu
force-pushed
the
remove-enable-flag
branch
from
d3f4093 to
b7627ba
Compare
|
No use case left for this flag. Commodore should be mostly smart enough to allow removing the component if absolutely necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any OpenShift 3 clusters left, and don't need this parameter anymore. Since #47 will be a breaking change anyway, it makes sense to also remove the parameter.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog