-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gis: fix user warning when testing geo schelling example #189
gis: fix user warning when testing geo schelling example #189
Conversation
pre-commit.ci autofix |
Thanks! Could you explain briefly what the warning was and this fixes it? |
Sure! Sorry that I didn't provide more info. Basically the raw data contains a set of polygons, and we want to create a graph out of it, where a node represents a polygon, and a link between two polygons means that they are touch neighbors (or in other words, adjacent polygons). But the polygons in our data can be divided into several groups, and there's no link in-between these groups. I simply keep the largest group for the model. In Alternatively, we could set |
Awesome! Could you rebase/update this PR? If correct, this is the one that will turn it green! If you find the current warnings settings too strict for Mesa-geo, we could also remove the |
232ec44
to
5ae3a58
Compare
pre-commit.ci autofix |
Rebased! We can probably keep the current warning settings for now and decide later: ) |
Need to rush to a meeting and will check this later |
Green!!! Awesome. |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci update
5ae3a58
to
a304bfd
Compare
Fixed pre-commit error and squashed all commits into one. |
Go ahead, I approved already |
Thanks @EwoutH |
As part of #172.