Fix all GIS models

[EwoutH]

We just started testing our GIS models in CI (see #171), and currently unfortunately all 7 models that are tested present one or multiple errors

The errors are visible in any recent CI run of the Test GIS models workflow. They can also be reproduced and tested locally by running the test_gis_examples.py script with pytest.

Current errors

• GeoSchelling
  • Fix missing file: data/nuts_rg_60M_2013_lvl_2.geojson
  • Fix missing Model initialization
  • UserWarning: The weights matrix is not fully connected:
• GeoSchellingPoints
  • Fix missing file: data/nuts_rg_60M_2013_lvl_2.geojson
• Rainfall
  • Fix missing file: /vsigzip/data/elevation.asc.gz
  • Fix missing Model initialization
  • RasterLayer doesn't have access to Model (mesa-geo#236)
• Population
  • Fix missing file: /vsizip/data/clip.zip
  • Fix missing Model initialization
  • RasterLayer doesn't have access to Model (mesa-geo#236)
• AgentsAndNetworks
  • Provide the following required arguments (6312ebe):
    • campus
    • data_crs
    • buildings_file
    • walkway_file
    • lakes_file
    • rivers_file
    • driveway_file
    • num_commuters
  • unhashable type error (f24626e)
  • set output_dir (679b677)
• GeoSir
  • Fix missing file: data/TorontoNeighbourhoods.geojson
  • Fix missing Model initialization
• UrbanGrowth
  • Provide missing argument for RasterLayer.__init__(): model

PRs to fix any of these issues are very welcome!

Update:

• The missing geojson paths where fixed in Fix 3 data path imports in gis models #176
• The missing Model initialization is fixed in Add two missing super().__init__() to Mesa model initialization #175
• More data paths and model passing: Fix data paths and model passing in GIS examples #177
• Pass the model to RasterLayers: gis: Pass model to RasterLayer.from_file() #186
• Fix missing default parameters, paths and output_dir: fix tests for agents-networks gis example #187
• Fix user warning in GeoSchelling gis: fix user warning when testing geo schelling example #189

[EwoutH]

(help is wanted on all our issues, including the ones without this label, so removing it)

[EwoutH]

Made a couple of fixes, now that #175 and #176 are merged the first two models pass, GeoSchellingPoints and GeoSir. For now I'm going to leave it at that.

Five to go!

[EwoutH]

@wang-boyu Could you add sensible default values to the AgentsAndNetworks model?

mesa-examples/gis/agents_and_networks/src/model/model.py

Line 44 in 3d29e4c

class AgentsAndNetworks(mesa.Model):

Or maybe load them from:

mesa-examples/gis/agents_and_networks/scripts/run.py

Line 34 in 3d29e4c

model_params = {

[EwoutH]

All warnings resolved! The next thing that needs to happen, is the big backport to the mesa-2.x branch, to make sure they're there working, before we update them with Mesa 3.0 stuff.

[EwoutH]

The big backport was successful, working, CI tested GIS examples are now available both on the main and mesa-2.x branches.

Completed! Thanks @wang-boyu!

[wang-boyu]

GIS example tests were long overdue. Thanks for your work on this!