Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove case sensitivity for collocate fragment spreads #13

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Remove case sensitivity for collocate fragment spreads #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/rule-must-colocate-fragment-spreads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ function getGraphQLFragmentSpreads(graphQLAst) {
return fragmentSpreads;
}

function isFirstLetterUppercase(word) {
return /^\p{Lu}/u.test(word);
}

function getGraphQLFragmentDefinitionName(graphQLAst) {
let name = null;
visit(graphQLAst, {
Expand Down Expand Up @@ -171,11 +167,7 @@ function checkColocation(context) {
ImportDeclaration(node) {
if (node.importKind === 'value') {
node.specifiers.forEach(specifier => {
if (
allowNamedImports &&
specifier.imported &&
isFirstLetterUppercase(specifier.imported.name)
MartinNuc marked this conversation as resolved.
Show resolved Hide resolved
) {
if (allowNamedImports && specifier.imported) {
foundImportedModules.push({
type: 'namedImport',
value: specifier.imported.name
Expand Down
10 changes: 10 additions & 0 deletions test/must-colocate-fragment-spreads.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ ruleTester.run(
`,
options: [{allowNamedImports: true}]
},
{
code: `
import { useHook } from '@some/module';
graphql\`fragment foo on Page {
...useHook
}\`;
`,
options: [{allowNamedImports: true}]
},
`
const Component = require('../shared/component.js');
graphql\`fragment foo on Page {
Expand Down
Loading