Skip to content
This repository has been archived by the owner on Dec 27, 2024. It is now read-only.

feat(Internationalization): adds support for internationalization #497

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

LucasTemponi
Copy link
Contributor

@LucasTemponi LucasTemponi commented Nov 22, 2024

Summary πŸ“°

Adds support for internationalization

Details πŸ“š

Implements internationalization following Backstage's guidelines
Closes #491

Checklist βœ…

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

Testing Notes πŸ”¬

@LucasTemponi LucasTemponi requested review from kurtaking and a team as code owners November 22, 2024 19:07
Copy link

changeset-bot bot commented Nov 22, 2024

πŸ¦‹ Changeset detected

Latest commit: 9390322

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@procore-oss/backstage-plugin-announcements-react Minor
@procore-oss/backstage-plugin-announcements Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LucasTemponi LucasTemponi changed the title feat(Internationalization): adds support for internationalization #491 feat(Internationalization): adds support for internationalization Nov 22, 2024
@kurtaking
Copy link
Contributor

@LucasTemponi, the DCO step is failing. We can get this merged once you get that fixed.

Lucas Temponi added 3 commits November 25, 2024 15:43
@LucasTemponi
Copy link
Contributor Author

@kurtaking , commits signed off.

Sorry about that.

@gabrielcbe
Copy link
Contributor

@kurtaking, anything else we need to do on our side?

@kurtaking
Copy link
Contributor

@kurtaking, anything else we need to do on our side?

Taking a look now - I've been out the past two weeks.

@kurtaking
Copy link
Contributor

@LucasTemponi @gabrielcbe - sorry for the delay. This will be in the next release.

@kurtaking kurtaking merged commit e44fb0c into procore-oss:main Dec 6, 2024
3 checks passed
@gabrielcbe
Copy link
Contributor

@LucasTemponi @gabrielcbe - sorry for the delay. This will be in the next release.

No worries about the delay, thanks a lot for taking the time to review and merge the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸš€ Feature: add internationalization support
3 participants