This repository has been archived by the owner on Dec 27, 2024. It is now read-only.
add missing translationRef export necessary for internationalization #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61459f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kurtaking
suggested changes
Dec 23, 2024
Signed-off-by: Gabriel Becheleni <[email protected]> Signed-off-by: Gabriel Becheleni <[email protected]>
Signed-off-by: Gabriel Becheleni <[email protected]> Signed-off-by: Gabriel Becheleni <[email protected]>
Signed-off-by: Gabriel Becheleni <[email protected]> Signed-off-by: Gabriel Becheleni <[email protected]>
Signed-off-by: Gabriel Becheleni <[email protected]>
Signed-off-by: Gabriel Becheleni <[email protected]>
This reverts commit e41fd35. Signed-off-by: Gabriel Becheleni <[email protected]>
gabrielcbe
force-pushed
the
gabrielcbe-patch-export-translationRef
branch
from
fad062e to
31b977c
Compare
|
@gabrielcbe - add a changeset and we can merge this. |
Signed-off-by: Gabriel Becheleni <[email protected]>
|
@kurtaking, added back the changeset, the one before had changes to the main plugin too so I reverted. thanks a lot! |
kurtaking
suggested changes
Dec 26, 2024
Signed-off-by: Kurt King <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📰
In the previous PR we made to add adds support for internationalization, we forgot to add necessary export to the translationRef to be used by people using the plugin
Details 📚
added the necessary exports to the plugins to allow the intl to be used and translated inside their backstage instance
Checklist ✅
Testing Notes 🔬