Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds SPM build to CI #697

Merged
merged 36 commits into from
Oct 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
c90f5a3
Add UIKit import to Mock3DSService.swift
NQuinn27 Oct 3, 2023
a19d284
Added SPM version of Debug App for CI Builds
NQuinn27 Oct 3, 2023
cc3b03a
Build SPM Scheme in CI
NQuinn27 Oct 3, 2023
ef75df4
Merge branch 'master' into nq/CHKT-1784_SPM_Sample_app
NQuinn27 Oct 3, 2023
f623cc6
Reorder build
NQuinn27 Oct 3, 2023
7da6497
Merge branch 'nq/CHKT-1784_SPM_Sample_app' of github.com:primer-io/pr…
NQuinn27 Oct 3, 2023
b15caa5
update cocoapods version
NQuinn27 Oct 3, 2023
fb11020
Update cocoapods version
NQuinn27 Oct 3, 2023
d580443
Update ruby version
NQuinn27 Oct 3, 2023
117ac63
Test SPM solo build
NQuinn27 Oct 3, 2023
fc00b06
Add keychain passwords
NQuinn27 Oct 3, 2023
0c9b41e
Add keychain passwords
NQuinn27 Oct 3, 2023
eb2792a
Fix fastlane typo. Update Ruby version in lint
NQuinn27 Oct 3, 2023
dd6a23b
Add local package
NQuinn27 Oct 3, 2023
f552839
Separate SPM from Cocoapods using a project
NQuinn27 Oct 4, 2023
6d94fba
Use non-agvtool versioning
NQuinn27 Oct 4, 2023
f38e62f
Specify projects for builds
NQuinn27 Oct 4, 2023
d728edd
Share schemes with Workspace
NQuinn27 Oct 4, 2023
c98e68d
Fix project path in build action
NQuinn27 Oct 4, 2023
3ead5c4
Fix typo in block param
NQuinn27 Oct 4, 2023
4ba7c1d
Remove old set_version
NQuinn27 Oct 4, 2023
955d264
Pass options
NQuinn27 Oct 4, 2023
12e58ff
Revert to previous pre-build actions
NQuinn27 Oct 4, 2023
8c2f911
Correctly shared schemes
NQuinn27 Oct 4, 2023
a506057
Attempt older build number code
NQuinn27 Oct 4, 2023
1c5f778
Dont use agvtool at all
NQuinn27 Oct 4, 2023
086875d
Clean up unused lane
NQuinn27 Oct 4, 2023
eadbcf5
Try macos13
NQuinn27 Oct 4, 2023
0702397
Remove local dep from project
NQuinn27 Oct 4, 2023
f8c2633
Remove non building target
NQuinn27 Oct 4, 2023
eb72292
Fix hardcoded location
NQuinn27 Oct 4, 2023
f9234ec
Use workspace
NQuinn27 Oct 4, 2023
caf0343
re enable full run
NQuinn27 Oct 4, 2023
5051d55
Revert "Clean up unused lane"
NQuinn27 Oct 4, 2023
fed1d82
reinstate QA lane
NQuinn27 Oct 4, 2023
05864e6
Merge branch 'master' into nq/CHKT-1784_SPM_Sample_app
NQuinn27 Oct 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 48 additions & 3 deletions .github/workflows/build_test_upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,50 @@ jobs:
env:
GITHUB_TOKEN: ${{ github.token }}

spm-build:
needs: danger
runs-on: macos-13
timeout-minutes: 20
name: "Build app with SPM Integration"
steps:
- name: Cancel previous jobs
uses: styfle/[email protected]
with:
access_token: ${{ github.token }}
- name: Git - Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.ref }}
- name: Select Xcode Version
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '15.0'
- name: Install SSH key
uses: shimataro/ssh-key-action@v2
with:
key: ${{ secrets.SSH_KEY }}
name: id_rsa_github_actions
known_hosts: ${{ secrets.KNOWN_HOSTS }}
- uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_KEY }}
- uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2"
bundler-cache: true
- name: Build SPM App
run: |
bundle exec fastlane build_spm
env:
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
MATCH_GIT_PRIVATE_KEY: ${{ secrets.SSH_KEY }}
FASTLANE_PASSWORD: ${{ secrets.FASTLANE_PASSWORD }}
FASTLANE_SESSION: ${{ secrets.FASTLANE_SESSION }}
MATCH_KEYCHAIN_NAME: ${{ secrets.MATCH_KEYCHAIN_NAME }}
MATCH_KEYCHAIN_PASSWORD: ${{ secrets.MATCH_KEYCHAIN_PASSWORD }}
SOURCE_BRANCH: ${{ github.head_ref }}
PR_NUMBER: ${{ github.event.pull_request.number }}

build-and-upload-to-appetize:
needs: danger
runs-on: macos-latest
Expand Down Expand Up @@ -54,7 +98,7 @@ jobs:

- uses: ruby/setup-ruby@v1
with:
ruby-version: "2.6"
ruby-version: "3.2"
bundler-cache: true

- name: Setup node
Expand All @@ -64,6 +108,7 @@ jobs:

- run: npm install --save slack-message-builder


- name: Test, Build, and Distribute app to Appetize 🚀
run: |
bundle exec fastlane appetize_build_and_upload
Expand All @@ -77,7 +122,7 @@ jobs:
APPETIZE_API_TOKEN: ${{ secrets.APPETIZE_API_TOKEN }}
SOURCE_BRANCH: ${{ github.head_ref }}
PR_NUMBER: ${{ github.event.pull_request.number }}

- uses: peter-evans/find-comment@v2
if: ${{ success() }}
id: find_comment
Expand Down Expand Up @@ -156,7 +201,7 @@ jobs:

- uses: ruby/setup-ruby@v1
with:
ruby-version: "2.6"
ruby-version: "3.2"
bundler-cache: true

- name: Create Firebase Service Credentials file
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pod_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
with:
ruby-version: "2.6"
ruby-version: "3.2"
bundler-cache: true

- name: Lint pod
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build
name: Sonarcloud
on:
push:
branches:
Expand Down
1 change: 1 addition & 0 deletions Debug App/Podfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Uncomment the next line to define a global platform for your project
platform :ios, '11.0'
project 'Primer.io Debug App.xcodeproj'

target 'Debug App' do
# Comment the next line if you don't want to use dynamic frameworks
Expand Down
4 changes: 2 additions & 2 deletions Debug App/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ SPEC CHECKSUMS:
PrimerKlarnaSDK: de4b8b8fda075e3e4ebbd4ab80bd141c76a30d85
PrimerSDK: 68ed0270e950874a7a23929bf86f66b132ba048c

PODFILE CHECKSUM: b6c77786fa8316d9434fa57e0606ffe370fe5435
PODFILE CHECKSUM: 767fc2a30881175cd72482b91908fca025ea8bb9

COCOAPODS: 1.12.1
COCOAPODS: 1.13.0
4 changes: 2 additions & 2 deletions Debug App/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3,996 changes: 2,000 additions & 1,996 deletions Debug App/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading